Skip to content

Adds more detailed telemetry fields #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rossgrambo merged 10 commits into from
Oct 23, 2024
Merged

Adds more detailed telemetry fields #495

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ef0bfd4
Working allocationId
rossgrambo Sep 10, 2024
27330d7
Adds Base64Url byte extension, adjusts TelemetryEventHandler logic, a…
rossgrambo Sep 11, 2024
ba1676c
Update comments
rossgrambo Sep 11, 2024
ada8823
Removed allocation id and fixed some tests
rossgrambo Sep 13, 2024
85cdd0a
Removed bytes extension
rossgrambo Sep 16, 2024
f9cb776
Merge branch 'preview' into rossgrambo-extra-telemetry-fields
rossgrambo Oct 22, 2024
9406999
Update src/Microsoft.FeatureManagement/Telemetry/TelemetryEventHandle…
rossgrambo Oct 23, 2024
e53aeb0
Resolving comments
rossgrambo Oct 23, 2024
a904411
Merge branch 'rossgrambo-extra-telemetry-fields' of https://github.co…
rossgrambo Oct 23, 2024
4cb6a17
Fix formatting
rossgrambo Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/Microsoft.FeatureManagement/Telemetry/FeatureEvaluationTelemetry.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,13 +69,7 @@ public static void Publish(EvaluationEvent evaluationEvent, ILogger logger)
if (evaluationEvent.VariantAssignmentReason == VariantAssignmentReason.DefaultWhenEnabled)
{
// If the variant was assigned due to DefaultWhenEnabled, the percentage reflects the unallocated percentiles
double allocatedPercentage = 0;

if (evaluationEvent.FeatureDefinition.Allocation?.Percentile != null)
{
allocatedPercentage += evaluationEvent.FeatureDefinition.Allocation.Percentile
.Sum(p => p.To - p.From);
}
double allocatedPercentage = evaluationEvent.FeatureDefinition.Allocation?.Percentile?.Sum(p => p.To - p.From) ?? 0;

tags["VariantAssignmentPercentage"] = 100 - allocatedPercentage;
}
Expand Down