Cleanup tree-agent prompt generation #25475
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the tree-agent's prompt generation system to conditionally include editing information based on schema content and removes the unused IdGenerator class. The changes optimize LLM prompts by only including array/map/object editing instructions when those node types exist in the schema.
- Removes the IdGenerator class entirely as it's no longer needed
- Conditionally includes array and map editing documentation in prompts based on schema analysis
- Simplifies the querying system by removing ID generation and management
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/framework/tree-agent/src/idGenerator.ts | Complete removal of the IdGenerator class and its functionality |
| packages/framework/tree-agent/src/agent.ts | Refactored prompt generation to conditionally include editing instructions and removed IdGenerator usage |
| const simpleSchema = getSimpleSchema(schema); | ||
| // Inspect the schema to determine what kinds of nodes are possible - this will affect how much information we need to include in the prompt. |
There was a problem hiding this comment.
There's an extra space before 'how' in the comment. Should be 'this will affect how much information'.
Suggested change
| // Inspect the schema to determine what kinds of nodes are possible - this will affect how much information we need to include in the prompt. | |
| // Inspect the schema to determine what kinds of nodes are possible - this will affect how much information we need to include in the prompt. |
Copilot uses AI. Check for mistakes.
github-actions
bot
added
base: main
taylorsw04
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This does various small refactors and cleanups to tree-agent. The LLM prompt now only includes information about editing arrays, maps, and objects if the schema contains arrays, maps, and objects respectively. This PR also removes the IdGenerator as it is no longer used.