Skip to content

Conversation

sudivate
Copy link
Contributor

@sudivate sudivate commented Mar 24, 2020

@sudivate sudivate requested a review from eedorenko March 24, 2020 18:35
@sudivate
Copy link
Contributor Author

#227

@dtzar
Copy link
Contributor

dtzar commented Mar 24, 2020

Looking at the reference doc on how to do the authentication, it will likely take people some time to figure out to properly connect. Why not just disable the authentication by default and suggest people to enable it for production implementations?

@sudivate
Copy link
Contributor Author

Looking at the reference doc on how to do the authentication, it will likely take people some time to figure out to properly connect. Why not just disable the authentication by default and suggest people to enable it for production implementations?

Auth is enabled by default unless explicitly suppressed at the time of model deployment. Its good to keep it enabled as a best security practice. Existing smoke test for model post-deployment shows how to access service with auth.

@dtzar
Copy link
Contributor

dtzar commented Mar 24, 2020

Makes sense - I'd call out the line(s) of code the smoke test uses in the doc and we're good.

@sudivate
Copy link
Contributor Author

Makes sense - I'd call out the line(s) of code the smoke test uses in the doc and we're good.

Thank you . Done !

@eedorenko eedorenko merged commit f2dc7d7 into master Mar 25, 2020
@eedorenko eedorenko deleted the sudivate-aks-auth branch March 25, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants