Skip to content

Conversation

sudivate
Copy link
Contributor

@sudivate sudivate marked this pull request as ready for review March 25, 2020 02:14
@sudivate sudivate requested a review from eedorenko March 25, 2020 02:16
[Dockerfile](../environment_setup/Dockerfile).

**Note:** Additionally mcr.microsoft.com/mlops/python image is also tagged with amlsdk[version] e.g amlsdk1.1.5.1 and githubrelease[version] e.g. githubrelease131681 which helps in tracking the exact version of amlsdk and other python dependencies included in the image.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 131681 release number?
Can we go with just mcr.microsoft.com/mlops/python:[githubreleaseversion] (e.g. mcr.microsoft.com/mlops/python:3.0.0) instead of mcr.microsoft.com/mlops/python:githubrelease[version]
(e.g. mcr.microsoft.com/mlops/python:githubreleaseversion3.0.0) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amlsdk-[version]
githubreleaseversion-[version]

@eedorenko eedorenko merged commit a562b59 into master Mar 26, 2020
@eedorenko eedorenko deleted the sudivate-dockertag branch March 26, 2020 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants