Skip to content

Conversation

irvinesunday
Copy link
Contributor

This PR:

  • Updates the XML documentation for the HasOperations() method in the OpenApiUrlTreeNode.cs class.
  • Adds a nullability check for the label param in the above method.
  • Update tests for the above method to validate the nullability check.
  • [Bonus] Refactors out common code in the OpenApiUrlTreeNodeTests.cs into reusable private properties, and sorts all ArgumentExceptions tests to come after the rest of the other tests. This is to help in test organization.
  • [Bonus] Adds further tests to the ArgumentExceptions tests for Create() and Attach() methods.

This helps with simplifying the tests since we are abstracting out the plumbing work required for some of the tests. Since the code is repetitive, this can be refactored out and reused.
@irvinesunday irvinesunday self-assigned this Jun 7, 2021
@irvinesunday irvinesunday merged commit 2b3abef into microsoft:vnext Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants