Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Aug 1, 2021

No description provided.

Shahak Yosef and others added 11 commits March 22, 2021 16:48
File was not updated since 2016
If setAccessToken is empty we need to throw an error.
… of JS SDK

## This PR adds the following features in JS SDK:
1. Method to move visual - (Report, Page, Visual)
2. Method to resize visual - (Report, Page, Visual)
3. Method to show/ hide visual - (Report, Page, Visual)
4. Method to resize Page - (Report, Page)
5. Method to get active page - (Report)
6. Method to get slicers - (Page)
7. Method to add/ remove context menu - (Report)
8. Method to add/ remove options menu - (Report)
9. Filter builder classes

# Checklist
- [X]  Build and test scripts are passing, if available
- [X]  Open errors/warning details are shared with the reviewer
- [X]  There are no violations to the applicable coding guidelines
- [X]  Application has a consistent exception management setup
- [X]  Code does not contain commented code
- [X]  Is testing performed and results captured in ADO and list of test cases executed shared in PR?
- [X]  Generic exception type is not handled
- [X]  Stacktrace of error is not returned
- [X]  All external packages/libraries are installed from an online package manager

Related work items: #556945, #556982, #557990, #558047, #558568, #558774, #559269, #559270, #559675, #560267, #560343, #562588, #562621, #562622, #562623, #562689, #562693, #562694, #563307, #563335, #564462, #564992, #565015, #566324, #566493, #566939, #567286, #570360, #570361, #570466, #570469, #571363, #571440, #572234, #572247, #573012, #573015, #573664, #574414, #574522, #574523, #575744
…TopNFilterBuilder and rename resizePage to resizeActivePage

**This PR adds the following features in JS SDK:**
1. Rename resizePage to resizeActivePage at report level
2. Add orderByTarget method that receives a target so the user can provide a target object, and add the capability to support aggregation targets
3. Removed withTarget method

**Checklist**
- [X] Build and test scripts are passing, if available
- [X] Open errors/warning details are shared with the reviewer
- [X] There are no violations to the applicable coding guidelines
- [X] Application has a consistent exception management setup
- [X] Code does not contain commented code
- [X] Is testing performed and results captured in ADO and list of test cases executed shared in PR?
- [X] Generic exception type is not handled
- [X] Stacktrace of error is not returned
- [X] All external packages/libraries are installed from an online package manager

Related work items: #600574
**This PR adds the following features in JS SDK:**
1. Added below methods:
	withColumnTarget
	withMeasureTarget
	withHierarchyLevelTarget
	WithColumnAggregation
	withHierarchyLevelAggregationTarget
2. Added test cases

**Checklist**
- [X]  Build and test scripts are passing, if available
- [X]  Open errors/warning details are shared with the reviewer
- [X]  There are no violations to the applicable coding guidelines
- [X]  Application has a consistent exception management setup
- [X]  Code does not contain commented code
- [X]  Is testing performed and results captured in ADO and list of test cases executed shared in PR?
- [X]  Generic exception type is not handled
- [X]  Stacktrace of error is not returned
- [X]  All external packages/libraries are installed from an online package manager

Related work items: #605702
Add loadingScreenHidden event
Mirror one [external PR](#365 (comment)).
Update powerbi-models version.
Expose mobile view page size (when available)
From the end user's perspective, they will need to provide a third parameter to `powerbi.embed()` request.
The new input may be extended in the future to support other event hooks.

```javascript
powerbi.embed(..., config, { preQueryCallback: provideContext })
```
The code in `service.ts` is similar to the event listeners we set in the [constructor](https://powerbi.visualstudio.com/Embedded/_git/powerbi-javascript?path=%2Fsrc%2Fservice.ts&version=GBmaster&line=168&lineEnd=168&lineStartColumn=5&lineEndColumn=21&lineStyle=plain&_a=contents)
@ghost ghost requested review from ali-hamud, Guy-Moses and laurent-mic August 1, 2021 08:29
@ghost ghost merged commit 32b6e73 into master Aug 2, 2021
@ghost ghost deleted the version-1.8.4 branch August 2, 2021 08:03
@ghost ghost changed the title Version 1.8.4 Version 2.18.4 Oct 12, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants