-
Notifications
You must be signed in to change notification settings - Fork 477
Version 2.18.4 #378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Version 2.18.4 #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File was not updated since 2016
If setAccessToken is empty we need to throw an error.
… of JS SDK ## This PR adds the following features in JS SDK: 1. Method to move visual - (Report, Page, Visual) 2. Method to resize visual - (Report, Page, Visual) 3. Method to show/ hide visual - (Report, Page, Visual) 4. Method to resize Page - (Report, Page) 5. Method to get active page - (Report) 6. Method to get slicers - (Page) 7. Method to add/ remove context menu - (Report) 8. Method to add/ remove options menu - (Report) 9. Filter builder classes # Checklist - [X] Build and test scripts are passing, if available - [X] Open errors/warning details are shared with the reviewer - [X] There are no violations to the applicable coding guidelines - [X] Application has a consistent exception management setup - [X] Code does not contain commented code - [X] Is testing performed and results captured in ADO and list of test cases executed shared in PR? - [X] Generic exception type is not handled - [X] Stacktrace of error is not returned - [X] All external packages/libraries are installed from an online package manager Related work items: #556945, #556982, #557990, #558047, #558568, #558774, #559269, #559270, #559675, #560267, #560343, #562588, #562621, #562622, #562623, #562689, #562693, #562694, #563307, #563335, #564462, #564992, #565015, #566324, #566493, #566939, #567286, #570360, #570361, #570466, #570469, #571363, #571440, #572234, #572247, #573012, #573015, #573664, #574414, #574522, #574523, #575744
…TopNFilterBuilder and rename resizePage to resizeActivePage **This PR adds the following features in JS SDK:** 1. Rename resizePage to resizeActivePage at report level 2. Add orderByTarget method that receives a target so the user can provide a target object, and add the capability to support aggregation targets 3. Removed withTarget method **Checklist** - [X] Build and test scripts are passing, if available - [X] Open errors/warning details are shared with the reviewer - [X] There are no violations to the applicable coding guidelines - [X] Application has a consistent exception management setup - [X] Code does not contain commented code - [X] Is testing performed and results captured in ADO and list of test cases executed shared in PR? - [X] Generic exception type is not handled - [X] Stacktrace of error is not returned - [X] All external packages/libraries are installed from an online package manager Related work items: #600574
**This PR adds the following features in JS SDK:** 1. Added below methods: withColumnTarget withMeasureTarget withHierarchyLevelTarget WithColumnAggregation withHierarchyLevelAggregationTarget 2. Added test cases **Checklist** - [X] Build and test scripts are passing, if available - [X] Open errors/warning details are shared with the reviewer - [X] There are no violations to the applicable coding guidelines - [X] Application has a consistent exception management setup - [X] Code does not contain commented code - [X] Is testing performed and results captured in ADO and list of test cases executed shared in PR? - [X] Generic exception type is not handled - [X] Stacktrace of error is not returned - [X] All external packages/libraries are installed from an online package manager Related work items: #605702
Add loadingScreenHidden event Mirror one [external PR](#365 (comment)). Update powerbi-models version.
Expose mobile view page size (when available)
From the end user's perspective, they will need to provide a third parameter to `powerbi.embed()` request. The new input may be extended in the future to support other event hooks. ```javascript powerbi.embed(..., config, { preQueryCallback: provideContext }) ``` The code in `service.ts` is similar to the event listeners we set in the [constructor](https://powerbi.visualstudio.com/Embedded/_git/powerbi-javascript?path=%2Fsrc%2Fservice.ts&version=GBmaster&line=168&lineEnd=168&lineStartColumn=5&lineEndColumn=21&lineStyle=plain&_a=contents)
ali-hamud
approved these changes
Aug 2, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.