Browser Notification type definition incorrect

[chris-ls]

TypeScript Version: 2.2.1

Looking at lib.es6.d.ts we have

interface Notification extends EventTarget {
    // ...
    readonly permission: string;
    // ...
}

and

declare var Notification: {
    prototype: Notification;
    new(title: string, options?: NotificationOptions): Notification;
    requestPermission(callback?: NotificationPermissionCallback): Promise<string>;
}

The permission string is a static property on the Notification class.
i.e. We should have:

declare var Notification: {
    prototype: Notification;
    readonly permission: string;
    new(title: string, options?: NotificationOptions): Notification;
    requestPermission(callback?: NotificationPermissionCallback): Promise<string>;
}

and it should be removed from the Notification Interface definition.

[NNemec]

Just stumbled over the same issue a today...

[mhegazy]

Seems we are also missing maxActions as a static property on Notification

[mhegazy]

PRs welcomed. You can find more information about contributing lib.d.ts fixes at https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes.

[csgulyas]

I think this would require modifying browser.webidl.xml in the TSJS-lib-generator which the readme says don't, because it comes from Edge

[NNemec]

Does that mean that the actual bug is in Edge? Any hope to get it fixed there?
Or is the bug in Typescript using that file in a way that is not intended by Edge?

[csgulyas]

I'm not sure how browser.webidl.xml comes into existence, if it is a result of an extraction process from Edge, or Edge simply interprets it differently, but locally I tried to modify the file and re-generate dom.generated.d.ts.

I removed permission from the properties node and added it as a constant:

<interface name="Notification" extends="EventTarget">
	  <constants>
		<constant name="permission" type="NotificationPermission" />
	  </constants>
...

The output was more along the lines of what OP suggested

interface Notification extends EventTarget {
    ...
    readonly permission: NotificationPermission;
}

declare var Notification: {
    prototype: Notification;
    new(title: string, options?: NotificationOptions): Notification;
    readonly permission: NotificationPermission;
    requestPermission(callback?: NotificationPermissionCallback): Promise<NotificationPermission>;
}

I don't think the build tool supports removing things from the interface while keeping it in the var declaration, but I just started tinkering with it so I might wrong.