Skip to content

Allow JS multiple declarations of ctor properties #10123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sandersn merged 9 commits into from
Aug 17, 2016
Merged

Allow JS multiple declarations of ctor properties #10123

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8c01efb
Allow JS multiple declarations of ctor properties
sandersn Aug 3, 2016
7205750
Test that declares conflicting method first
sandersn Aug 3, 2016
798be6f
Add new test baseline and delete else in binder
sandersn Aug 4, 2016
8f638f7
Fix lint
sandersn Aug 5, 2016
cabd276
Fix more lint
sandersn Aug 5, 2016
2845d2f
Improve naming and documentation from PR
sandersn Aug 8, 2016
96840c3
Merge branch 'master' into allow-js-multiple-declaration-of-construct…
sandersn Aug 17, 2016
07a8f31
Correctly merge bindThisPropertyAssignment
sandersn Aug 17, 2016
c73efe2
Fix comment
sandersn Aug 17, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix comment
  • Loading branch information
@sandersn
sandersn committed Aug 17, 2016
commit c73efe2fb629bcb3a283eaf7979d7070705546cc
2 changes: 1 addition & 1 deletion src/compiler/binder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1989,9 +1989,9 @@ namespace ts {
// Bind this property to the containing class
const saveContainer = container;
container = container.parent;
// AND it can be overwritten by subsequent method declarations
const symbol = bindPropertyOrMethodOrAccessor(node, SymbolFlags.Property, SymbolFlags.None);
if (symbol) {
// constructor-declared symbols can be overwritten by subsequent method declarations
(symbol as Symbol).isReplaceableByMethod = true;
}
container = saveContainer;
Expand Down