Use lowercase names for type reference directives #10340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The code gets a 👍 from me, although I don't know enough about the feature so know whether this is a good idea. So maybe somebody else should review as well. |
Contributor
|
Can you please add a comment on why the use of lowercase is OK here. It will probably look strange for the next person touching this code base. |
Contributor
|
👍 |
ghost
merged commit 
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9824
Note: since we don't try un-lowercasing names on failure, this would break any code that intentionally used an uppercased name for a type reference, although that's not too likely since
@typesis the default and anything installed by npm will be lowercase.