Skip to content

Fix 10625: JSX Not validating when index signature is present #10352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuit merged 4 commits into from
Aug 16, 2016
Merged

Fix 10625: JSX Not validating when index signature is present #10352

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
12f7ed6
Check for type of property declaration before using index signature
Aug 15, 2016
5f88566
Add tests and baselines
Aug 15, 2016
0b7fdd6
Merge branch 'master' into fix10625
Aug 15, 2016
3fd6bfe
fix linting error
Aug 15, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Check for type of property declaration before using index signature
  • Loading branch information
Kanchalai Tanglertsampan committed Aug 15, 2016
commit 12f7ed682a594a7e277a745058dd596519045f78
7 changes: 3 additions & 4 deletions src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10125,10 +10125,9 @@ namespace ts {
const correspondingPropSymbol = getPropertyOfType(elementAttributesType, node.name.text);
correspondingPropType = correspondingPropSymbol && getTypeOfSymbol(correspondingPropSymbol);
if (isUnhyphenatedJsxName(node.name.text)) {
// Maybe there's a string indexer?
const indexerType = getIndexTypeOfType(elementAttributesType, IndexKind.String);
if (indexerType) {
correspondingPropType = indexerType;
const attributeType = getTypeOfPropertyOfType(elementAttributesType, getTextOfPropertyName(node.name)) || getIndexTypeOfType(elementAttributesType, IndexKind.String);
if (attributeType) {
correspondingPropType = attributeType;
}
else {
// If there's no corresponding property with this name, error
Expand Down