Skip to content

Named Type Arguments & Partial Type Argument Inference #23696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
weswigham wants to merge 14 commits into from
Closed

Named Type Arguments & Partial Type Argument Inference #23696

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b881226
Basic parsing+handling code that is aware of named type arguments, no…
weswigham Apr 20, 2018
a75efc4
Fix small jsx inference bug
weswigham Apr 24, 2018
e578802
A a big pile of error messages
weswigham Apr 24, 2018
65700dc
Small fix + refactor, lint fix
weswigham Apr 25, 2018
b526f5d
handle defaults
weswigham Apr 26, 2018
fc69ca4
Merge branch 'master' into named-type-arguments-beta
weswigham Apr 26, 2018
d71f989
Inline variables
weswigham Apr 26, 2018
5185c77
Handle defaults better
weswigham Apr 26, 2018
59f66dd
Update comments, simplify getSyntheticInferType
weswigham Apr 27, 2018
26ad385
Merge branch 'master' into named-type-arguments-beta
weswigham May 3, 2018
7a108ce
Error number changes form merge
weswigham May 3, 2018
63731ba
Merge commit '3fe946df78c270817192c9eb7a22e7111c8a592a' into named-ty…
weswigham May 23, 2018
1a6154a
Merge branch 'master' into named-type-arguments-beta
weswigham May 23, 2018
9d9d57e
Merge branch 'master' into named-type-arguments-beta
weswigham May 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Error number changes form merge
  • Loading branch information
@weswigham
weswigham committed May 3, 2018
commit 7a108ce4f172674b3077077b5ed1981a1bad8667
92 changes: 46 additions & 46 deletions tests/baselines/reference/typeArgumentListsWithNamedTypeArgumentErrors.errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(28,35): error TS1346: Signature has no type argument named 'Q'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(29,29): error TS1346: Signature has no type argument named 'Q'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(30,29): error TS1346: Signature has no type argument named 'Q'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(31,33): error TS1346: Signature has no type argument named 'Q'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(32,14): error TS1350: No value provided for required type argument 'U'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(32,22): error TS1346: Signature has no type argument named 'Q'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(36,27): error TS1345: Positional type argument conflicts with named type argument 'T'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(36,35): error TS1344: Named type argument conflicts with positional type argument at index '0'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(37,21): error TS1345: Positional type argument conflicts with named type argument 'T'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(37,29): error TS1344: Named type argument conflicts with positional type argument at index '0'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(38,21): error TS1345: Positional type argument conflicts with named type argument 'T'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(38,29): error TS1344: Named type argument conflicts with positional type argument at index '0'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(39,25): error TS1345: Positional type argument conflicts with named type argument 'T'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(39,33): error TS1344: Named type argument conflicts with positional type argument at index '0'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(40,14): error TS1345: Positional type argument conflicts with named type argument 'T'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(40,14): error TS1350: No value provided for required type argument 'U'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(40,22): error TS1344: Named type argument conflicts with positional type argument at index '0'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(28,35): error TS1347: Signature has no type argument named 'Q'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(29,29): error TS1347: Signature has no type argument named 'Q'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(30,29): error TS1347: Signature has no type argument named 'Q'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(31,33): error TS1347: Signature has no type argument named 'Q'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(32,14): error TS1351: No value provided for required type argument 'U'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(32,22): error TS1347: Signature has no type argument named 'Q'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(36,27): error TS1346: Positional type argument conflicts with named type argument 'T'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(36,35): error TS1345: Named type argument conflicts with positional type argument at index '0'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(37,21): error TS1346: Positional type argument conflicts with named type argument 'T'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(37,29): error TS1345: Named type argument conflicts with positional type argument at index '0'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(38,21): error TS1346: Positional type argument conflicts with named type argument 'T'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(38,29): error TS1345: Named type argument conflicts with positional type argument at index '0'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(39,25): error TS1346: Positional type argument conflicts with named type argument 'T'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(39,33): error TS1345: Named type argument conflicts with positional type argument at index '0'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(40,14): error TS1346: Positional type argument conflicts with named type argument 'T'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(40,14): error TS1351: No value provided for required type argument 'U'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(40,22): error TS1345: Named type argument conflicts with positional type argument at index '0'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(44,27): error TS2300: Duplicate identifier 'T'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(44,39): error TS2300: Duplicate identifier 'T'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(44,51): error TS2345: Argument of type '0' is not assignable to parameter of type 'string'.
Expand All @@ -32,18 +32,18 @@ tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentLists
Type 'number' is not assignable to type 'string'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(47,88): error TS2339: Property 'toFixed' does not exist on type 'string'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(48,14): error TS2300: Duplicate identifier 'T'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(48,14): error TS1350: No value provided for required type argument 'U'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(48,14): error TS1351: No value provided for required type argument 'U'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(48,26): error TS2300: Duplicate identifier 'T'.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(52,27): error TS2558: Expected 0-2 type arguments, but got 3.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(53,21): error TS2558: Expected 0-2 type arguments, but got 3.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(54,21): error TS2558: Expected 0-2 type arguments, but got 3.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(55,25): error TS2558: Expected 0-2 type arguments, but got 3.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(56,10): error TS2314: Generic type 'Foo<T, U>' requires 2 type argument(s).
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(60,39): error TS1343: Positional type arguments cannot follow named type arguments.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(61,33): error TS1343: Positional type arguments cannot follow named type arguments.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(62,33): error TS1343: Positional type arguments cannot follow named type arguments.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(63,37): error TS1343: Positional type arguments cannot follow named type arguments.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(64,26): error TS1343: Positional type arguments cannot follow named type arguments.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(60,39): error TS1344: Positional type arguments cannot follow named type arguments.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(61,33): error TS1344: Positional type arguments cannot follow named type arguments.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(62,33): error TS1344: Positional type arguments cannot follow named type arguments.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(63,37): error TS1344: Positional type arguments cannot follow named type arguments.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(64,26): error TS1344: Positional type arguments cannot follow named type arguments.
tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentListsWithNamedTypeArguments/typeArgumentListsWithNamedTypeArgumentErrors.tsx(67,10): error TS2314: Generic type 'Foo<T, U>' requires 2 type argument(s).


Expand Down Expand Up @@ -77,51 +77,51 @@ tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentLists

const instance1 = new Foo<number, Q = string>(0, "");
~
!!! error TS1346: Signature has no type argument named 'Q'.
!!! error TS1347: Signature has no type argument named 'Q'.
const result1 = foo<number, Q = string>(0, "");
~
!!! error TS1346: Signature has no type argument named 'Q'.
!!! error TS1347: Signature has no type argument named 'Q'.
const tagged1 = tag<number, Q = string>`tags ${12} ${""}`;
~
!!! error TS1346: Signature has no type argument named 'Q'.
!!! error TS1347: Signature has no type argument named 'Q'.
const jsx1 = <Component<number, Q = string> x={12} y="" cb={props => void (props.x.toFixed() + props.y.toUpperCase())} />;
~
!!! error TS1346: Signature has no type argument named 'Q'.
!!! error TS1347: Signature has no type argument named 'Q'.
type A = Foo<number, Q = string>;
~~~~~~~~~~~~~~~~~~
!!! error TS1350: No value provided for required type argument 'U'.
!!! error TS1351: No value provided for required type argument 'U'.
~
!!! error TS1346: Signature has no type argument named 'Q'.
!!! error TS1347: Signature has no type argument named 'Q'.

// Duplicates positional

const instance2 = new Foo<number, T = string>(0, "");
~~~~~~
!!! error TS1345: Positional type argument conflicts with named type argument 'T'.
!!! error TS1346: Positional type argument conflicts with named type argument 'T'.
~
!!! error TS1344: Named type argument conflicts with positional type argument at index '0'.
!!! error TS1345: Named type argument conflicts with positional type argument at index '0'.
const result2 = foo<number, T = string>(0, "");
~~~~~~
!!! error TS1345: Positional type argument conflicts with named type argument 'T'.
!!! error TS1346: Positional type argument conflicts with named type argument 'T'.
~
!!! error TS1344: Named type argument conflicts with positional type argument at index '0'.
!!! error TS1345: Named type argument conflicts with positional type argument at index '0'.
const tagged2 = tag<number, T = string>`tags ${12} ${""}`;
~~~~~~
!!! error TS1345: Positional type argument conflicts with named type argument 'T'.
!!! error TS1346: Positional type argument conflicts with named type argument 'T'.
~
!!! error TS1344: Named type argument conflicts with positional type argument at index '0'.
!!! error TS1345: Named type argument conflicts with positional type argument at index '0'.
const jsx2 = <Component<number, T = string> x={12} y="" cb={props => void (props.x.toFixed() + props.y.toUpperCase())} />;
~~~~~~
!!! error TS1345: Positional type argument conflicts with named type argument 'T'.
!!! error TS1346: Positional type argument conflicts with named type argument 'T'.
~
!!! error TS1344: Named type argument conflicts with positional type argument at index '0'.
!!! error TS1345: Named type argument conflicts with positional type argument at index '0'.
type B = Foo<number, T = string>;
~~~~~~
!!! error TS1345: Positional type argument conflicts with named type argument 'T'.
!!! error TS1346: Positional type argument conflicts with named type argument 'T'.
~~~~~~~~~~~~~~~~~~
!!! error TS1350: No value provided for required type argument 'U'.
!!! error TS1351: No value provided for required type argument 'U'.
~
!!! error TS1344: Named type argument conflicts with positional type argument at index '0'.
!!! error TS1345: Named type argument conflicts with positional type argument at index '0'.

// Duplicates other named

Expand Down Expand Up @@ -161,7 +161,7 @@ tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentLists
~
!!! error TS2300: Duplicate identifier 'T'.
~~~~~~~~~~~~~~~~~~~~~~
!!! error TS1350: No value provided for required type argument 'U'.
!!! error TS1351: No value provided for required type argument 'U'.
~
!!! error TS2300: Duplicate identifier 'T'.

Expand All @@ -187,19 +187,19 @@ tests/cases/conformance/types/typeParameters/typeArgumentLists/typeArgumentLists

const instance5 = new Foo<U = string, number>(0, "");
~~~~~~
!!! error TS1343: Positional type arguments cannot follow named type arguments.
!!! error TS1344: Positional type arguments cannot follow named type arguments.
const result5 = foo<U = string, number>(0, "");
~~~~~~
!!! error TS1343: Positional type arguments cannot follow named type arguments.
!!! error TS1344: Positional type arguments cannot follow named type arguments.
const tagged5 = tag<U = string, number>`tags ${12} ${""}`;
~~~~~~
!!! error TS1343: Positional type arguments cannot follow named type arguments.
!!! error TS1344: Positional type arguments cannot follow named type arguments.
const jsx5 = <Component<U = string, number> x={12} y="" cb={props => void (props.x.toFixed() + props.y.toUpperCase())} />;
~~~~~~
!!! error TS1343: Positional type arguments cannot follow named type arguments.
!!! error TS1344: Positional type arguments cannot follow named type arguments.
type E = Foo<U = string, number>;
~~~~~~
!!! error TS1343: Positional type arguments cannot follow named type arguments.
!!! error TS1344: Positional type arguments cannot follow named type arguments.

// Typespace only - does not provide enough arguments
type F = Foo<U = number>;
Expand Down
Loading