Skip to content

Package declaration file for commonjs packages #3159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rbuckton wants to merge 13 commits into from
Closed

Package declaration file for commonjs packages #3159

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
094afb2
Added single-file package declaration using multiple ambient modules
rbuckton May 7, 2015
03b5cc3
Updated format for submodule urls in a package
rbuckton May 8, 2015
57a81e6
Updated services and harnesses and added a test
rbuckton May 8, 2015
8a1c7c5
fixed harness to support packageDeclaration
rbuckton May 8, 2015
895a096
Cleanup, bug fixes
rbuckton May 9, 2015
28438bf
Updated test harness
rbuckton May 10, 2015
1f86bfa
Some cleanup and reorganization of code
rbuckton May 11, 2015
567b48a
Merge branch 'packageDeclaration2' of https://github.com/Microsoft/Ty…
rbuckton May 12, 2015
073da99
Added support for package paths in ImportEqualsDeclaration emit
rbuckton May 13, 2015
5f41f68
Cleaned up package parameters, added packageDir option, added path co…
rbuckton May 14, 2015
b001006
Added paramType for packageDir
rbuckton May 14, 2015
1ecd2e7
Additional compiler option cleanup
rbuckton May 14, 2015
1266290
Merged branch 'master' into packageDeclaration2
rbuckton May 14, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions src/harness/harness.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1162,12 +1162,20 @@ module Harness {
options?: ts.CompilerOptions,
// Current directory is needed for rwcRunner to be able to use currentDirectory defined in json file
currentDirectory?: string) {
if (options.declaration && result.errors.length === 0 && (options.packageDeclaration ? result.declFilesCode.length !== 1 : result.declFilesCode.length !== result.files.length)) {
let expectedDeclFileCount = 0;
if (options.declaration) {
expectedDeclFileCount += result.files.length;
}
if (options.packageDeclaration) {
expectedDeclFileCount++;
}

if ((options.declaration || options.packageDeclaration) && result.errors.length === 0 && (result.declFilesCode.length !== expectedDeclFileCount)) {
throw new Error('There were no errors and declFiles generated did not match number of js files generated');
}

// if the .d.ts is non-empty, confirm it compiles correctly as well
if (options.declaration && result.errors.length === 0 && result.declFilesCode.length > 0) {
if ((options.declaration || options.packageDeclaration) && result.errors.length === 0 && result.declFilesCode.length > 0) {
var declInputFiles: { unitName: string; content: string }[] = [];
var declOtherFiles: { unitName: string; content: string }[] = [];
var declResult: Harness.Compiler.CompilerResult;
Expand All @@ -1176,13 +1184,10 @@ module Harness {
if (file) {
declInputFiles.push({ unitName: file.fileName, content: file.code });
}
ts.forEach(inputFiles, file => isDTS(file.unitName) && declInputFiles.push(file));
ts.forEach(otherFiles, file => isDTS(file.unitName) && declOtherFiles.push(file));
}
else {
ts.forEach(inputFiles, file => addDtsFile(file, declInputFiles));
ts.forEach(otherFiles, file => addDtsFile(file, declOtherFiles));
}

ts.forEach(inputFiles, file => addDtsFile(file, declInputFiles));
ts.forEach(otherFiles, file => addDtsFile(file, declOtherFiles));

this.compileFiles(declInputFiles, declOtherFiles, function (compileResult) { declResult = compileResult; },
settingsCallback, options, currentDirectory);
Expand All @@ -1193,7 +1198,7 @@ module Harness {
if (isDTS(file.unitName)) {
dtsFiles.push(file);
}
else if (isTS(file.unitName)) {
else if (isTS(file.unitName) && options.declaration) {
var declFile = findResultCodeFile(file.unitName);
if (!findUnit(declFile.fileName, declInputFiles) && !findUnit(declFile.fileName, declOtherFiles)) {
dtsFiles.push({ unitName: declFile.fileName, content: declFile.code });
Expand Down
1 change: 0 additions & 1 deletion tests/cases/compiler/packageDeclarationEmit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
// @module: commonjs
// @target: es5
// @declaration: true
// @packageName: app
// @packageMain: index.ts
// @packageDeclaration: app.d.ts
Expand Down