Skip to content

Ensure original files are included in tsconfig.release.json #34584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2019
Merged

Ensure original files are included in tsconfig.release.json #34584

merged 1 commit into from
Oct 19, 2019

Conversation

@DanielRosenwasser
Copy link
Member

@DanielRosenwasser DanielRosenwasser commented Oct 18, 2019

Fixes #34583

sheetalkamat
sheetalkamat approved these changes Oct 19, 2019
View reviewed changes
Copy link
Member

@sheetalkamat sheetalkamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about missing this change

@DanielRosenwasser
Copy link
Member Author

DanielRosenwasser commented Oct 19, 2019

No worries, the compiler tsconfig.json already did something close - though, the tsconfig.release.jsons are all still different, so I don't know the extent to which that's a problem.

@DanielRosenwasser DanielRosenwasser merged commit f334654 into master Oct 19, 2019
@DanielRosenwasser DanielRosenwasser deleted the fixTscFilesList branch October 19, 2019 00:35
@DanielRosenwasser DanielRosenwasser mentioned this pull request Oct 21, 2019
Merged
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sheetalkamat sheetalkamat sheetalkamat approved these changes

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

Assignees

@DanielRosenwasser DanielRosenwasser

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LKG builds are failing

3 participants

@DanielRosenwasser @sheetalkamat