Skip to content

Check combined intersection properties against target index signatures #35143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 10, 2020
Merged

Check combined intersection properties against target index signatures #35143

merged 8 commits into from
Jan 10, 2020

Conversation

@ahejlsberg
Copy link
Member

@ahejlsberg ahejlsberg commented Nov 16, 2019

With this PR we check that all constituents of an intersection source type relate to index signatures in the target type. For example:

declare let s: { a: string } & { b: number };
declare let t: { [key: string]: string };
t = s;  // Error

Previously, no error was reported above.

Fixes #32484.

@ahejlsberg ahejlsberg mentioned this pull request Nov 16, 2019
Closed
@ahejlsberg
Copy link
Member Author

ahejlsberg commented Nov 16, 2019

@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 16, 2019 •
edited
Loading

Heya @ahejlsberg, I've started to run the parallelized community code test suite on this PR at b1f746b. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 16, 2019 •
edited
Loading

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at b1f746b. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 16, 2019 •
edited
Loading

Heya @ahejlsberg, I've started to run the extended test suite on this PR at b1f746b. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot typescript-bot mentioned this pull request Nov 16, 2019
Closed
@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 16, 2019

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@ahejlsberg
Copy link
Member Author

ahejlsberg commented Nov 17, 2019

@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 17, 2019 •
edited
Loading

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 3d8a9c8. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 17, 2019 •
edited
Loading

Heya @ahejlsberg, I've started to run the parallelized community code test suite on this PR at 3d8a9c8. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 17, 2019 •
edited
Loading

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 3d8a9c8. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 17, 2019

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@typescript-bot typescript-bot mentioned this pull request Nov 17, 2019
Closed
@ahejlsberg
Copy link
Member Author

ahejlsberg commented Jan 9, 2020

@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 9, 2020 •
edited
Loading

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 0ace61c. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 9, 2020 •
edited
Loading

Heya @ahejlsberg, I've started to run the parallelized community code test suite on this PR at 0ace61c. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 9, 2020 •
edited
Loading

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 0ace61c. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot typescript-bot mentioned this pull request Jan 9, 2020
Closed
@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 9, 2020

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@ahejlsberg
Copy link
Member Author

ahejlsberg commented Jan 9, 2020

@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 9, 2020 •
edited
Loading

Heya @ahejlsberg, I've started to run the parallelized community code test suite on this PR at f87aea3. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 9, 2020 •
edited
Loading

Heya @ahejlsberg, I've started to run the extended test suite on this PR at f87aea3. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 9, 2020 •
edited
Loading

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at f87aea3. You can monitor the build here. It should now contribute to this PR's status checks.

@ahejlsberg
Copy link
Member Author

ahejlsberg commented Jan 9, 2020

Issues in test suites are all preexisting conditions.

@ahejlsberg ahejlsberg merged commit 357f715 into master Jan 10, 2020
Kingwl pushed a commit to Kingwl/TypeScript that referenced this pull request Mar 4, 2020
@ahejlsberg @Kingwl
Check combined intersection properties against target index signatures (
1bac449 
microsoft#35143)

* Check combined intersection properties against target index signatures

* Add tests

* Accept new baselines

* Less aggressive check for index signatures

* Track intersection membership state for both source and target

* Minor fixes
@ahejlsberg ahejlsberg mentioned this pull request Mar 12, 2020
Closed
@phiresky phiresky mentioned this pull request May 23, 2020
Closed
@jakebailey jakebailey deleted the fix32484-2 branch November 7, 2022 17:34
@jakebailey jakebailey mentioned this pull request Jul 11, 2023
Closed
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

@weswigham weswigham Awaiting requested review from weswigham

Assignees

@ahejlsberg ahejlsberg

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

When creating a mapped type of an indexed type it extends too liberal

4 participants

@ahejlsberg @typescript-bot @RyanCavanaugh