Skip to content

Conversation

@a-tarasyuk
Copy link
Contributor

@a-tarasyuk a-tarasyuk commented Feb 10, 2020

Fixes #33377
Fixes #31507

@a-tarasyuk a-tarasyuk changed the title fix(33377): use quoteStyle option for string literals completions fix(33377): completions for string literals don't follow quoteStyle preference Feb 10, 2020
@sandersn sandersn added the For Milestone Bug PRs that fix a bug with a specific milestone label Feb 20, 2020
@sandersn
Copy link
Member

@sheetalkamat this is ready to go, right?

@a-tarasyuk
Copy link
Contributor Author

Seems this PR resolves two issues

#33377
#31507

cc @sandersn @sheetalkamat @DanielRosenwasser

@sandersn
Copy link
Member

(I edited the description to include the second bug)

@sandersn sandersn merged commit c8147cb into microsoft:master Feb 20, 2020
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Milestone Bug PRs that fix a bug with a specific milestone

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

completions for string literals don't follow quoteStyle preference Quote preference not used for literal type completions

3 participants