Skip to content

Add a switch for reporting expensive statements #37785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amcasey wants to merge 12 commits into from
Closed

Add a switch for reporting expensive statements #37785

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
52e2ce9
Track a fixed number of most-expensive statements
amcasey Apr 2, 2020
ebf8288
Take the number of statements to report from a switch
amcasey Apr 4, 2020
86fbb03
Report the most expensive statements as diagnostics
amcasey Apr 4, 2020
3fac294
Process .d.ts files before other files
amcasey Jun 5, 2020
3ddf1ff
Ignore expensive statements in .d.ts files
amcasey Jul 23, 2020
36b2865
Include type alias and interface declarations
amcasey Jul 23, 2020
8f5e138
Update baselines to reflect earlier processing of .d.ts files
amcasey Jul 23, 2020
2e2dfd4
Suppress ancestors of expensive statements to reduce noise
amcasey Aug 4, 2020
906c503
Skip unnecessary work more thoroughly
amcasey Aug 4, 2020
9d24de1
Add experimental support for expensive expressions
amcasey Aug 5, 2020
e15bec8
Add missing semicolon
amcasey Aug 5, 2020
ca645f8
Discount literal types
amcasey Aug 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ignore expensive statements in .d.ts files 
...rather than just dropping the first one, now that .d.ts file checking
is front-loaded.
  • Loading branch information
@amcasey
amcasey committed Aug 4, 2020
commit 3ddf1ff608ca1ad6c6e8fdbd99a0b6f7030a751c
13 changes: 6 additions & 7 deletions src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ namespace ts {
const keyofStringsOnly = !!compilerOptions.keyofStringsOnly;
const freshObjectLiteralFlag = compilerOptions.suppressExcessPropertyErrors ? 0 : ObjectFlags.FreshLiteral;

let ignoreExpensiveStatement = true;
let checkingDtsFile: boolean;
const maxExpensiveStatementCount = compilerOptions.expensiveStatements ?? 0;
const expensiveStatements: ExpensiveStatement[] = [];

Expand Down Expand Up @@ -35667,12 +35667,9 @@ namespace ts {

checkSourceElementWorker(node);

if (node.kind >= SyntaxKind.FirstStatement && node.kind <= SyntaxKind.LastStatement) {
if (ignoreExpensiveStatement) {
// The first statement is unfairly blamed for a lot of lib types
ignoreExpensiveStatement = false;
}
else {
// Never report expensive statements in .d.ts files
if (!checkingDtsFile) {
if (node.kind >= SyntaxKind.FirstStatement && node.kind <= SyntaxKind.LastStatement) {
const typeDelta = typeCount - oldTypeCount;
const symbolDelta = symbolCount - oldSymbolCount;
const record = { node, typeDelta, symbolDelta };
Expand Down Expand Up @@ -36011,10 +36008,12 @@ namespace ts {
}

function checkSourceFile(node: SourceFile) {
checkingDtsFile = fileExtensionIs(node.path, Extension.Dts);
performance.mark("beforeCheck");
checkSourceFileWorker(node);
performance.mark("afterCheck");
performance.measure("Check", "beforeCheck", "afterCheck");
checkingDtsFile = false;
}

function unusedIsError(kind: UnusedKind, isAmbient: boolean): boolean {
Expand Down