Handel inaccisible symbol errors

src/compiler/checker.ts

@@ -1567,6 +1567,11 @@ namespace ts {
                             }
                         }
                         else {
+
+                            if (!parentSymbol) {
+                                writer.trackInaccesibleSymbol(symbol);
+                            }
+
                             // If we didn't find accessible symbol chain for this symbol, break if this is external module
                             if (!parentSymbol && ts.forEach(symbol.declarations, hasExternalModuleSymbol)) {
                                 return;

src/compiler/declarationEmitter.ts

@@ -128,6 +128,7 @@ namespace ts {
         function createNewTextWriterWithSymbolWriter(): EmitTextWriterWithSymbolWriter {
             let writer = <EmitTextWriterWithSymbolWriter>createTextWriter(newLine);
             writer.trackSymbol = trackSymbol;
+            writer.trackInaccesibleSymbol = trackInaccesibleSymbol;
             writer.writeKeyword = writer.write;
             writer.writeOperator = writer.write;
             writer.writePunctuation = writer.write;
@@ -154,6 +155,12 @@ namespace ts {
             }
         }
 
+        function trackInaccesibleSymbol(symbol: Symbol): void {
+            if (currentErrorNode) {
+                reportUnamedDeclarationMessage(currentErrorNode);
+            }
+        }
+
         function emitTypeOfDeclaration(declaration: AccessorDeclaration | VariableLikeDeclaration, type: TypeNode) {
             write(": ");
             if (type) {
@@ -1525,6 +1532,53 @@ namespace ts {
             Debug.fail("Could not find container node");
         }
 
+        function reportUnamedDeclarationMessage(errorNode: Node): void {
+            reportedDeclarationError = true;
+            let container = errorNode;
+
+            while (container) {
+                switch (container.kind) {
+                    case SyntaxKind.BindingElement:
+                    case SyntaxKind.VariableDeclaration:
+                        diagnostics.push(createDiagnosticForNode(errorNode,
+                            Diagnostics.Name_of_inferred_type_of_variable_0_could_not_be_written_Consider_adding_an_explicit_type_annotation,
+                            getNameText(<VariableDeclaration>container)));
+                        return;
+                    case SyntaxKind.PropertySignature:
+                    case SyntaxKind.PropertyDeclaration:
+                    case SyntaxKind.SetAccessor:
+                    case SyntaxKind.GetAccessor:
+                        diagnostics.push(createDiagnosticForNode(errorNode,
+                            Diagnostics.Name_of_inferred_type_of_property_0_could_not_be_written_Consider_adding_an_explicit_type_annotation,
+                            getNameText(<PropertyDeclaration>container)));
+                        return;
+                    case SyntaxKind.Parameter:
+                        diagnostics.push(createDiagnosticForNode(errorNode,
+                            Diagnostics.Name_of_inferred_type_of_parameter_0_could_not_be_written_Consider_adding_an_explicit_type_annotation,
+                            getNameText(<ParameterDeclaration>container)));
+                        return;
+                    case SyntaxKind.MethodDeclaration:
+                    case SyntaxKind.MethodSignature:
+                        diagnostics.push(createDiagnosticForNode(errorNode,
+                            Diagnostics.Name_of_inferred_return_type_of_method_0_could_not_be_written_Consider_adding_an_explicit_type_annotation,
+                            getNameText(<MethodDeclaration>container)));
+                        return;
+                    case SyntaxKind.FunctionDeclaration:
+                        diagnostics.push(createDiagnosticForNode(errorNode,
+                            Diagnostics.Name_of_inferred_return_type_of_function_0_could_not_be_written_Consider_adding_an_explicit_type_annotation,
+                            getNameText(<FunctionDeclaration>container)));
+                        return;
+                    case SyntaxKind.ExportAssignment:
+                        diagnostics.push(createDiagnosticForNode(errorNode,
+                            Diagnostics.Name_of_inferred_type_of_default_export_could_not_be_written_Consider_exporting_a_declaration_instead));
+                        return;
+                }
+                container = container.parent;
+            }
+
+            Debug.fail("Could not find container node");
+        }
+
         function collectDeclaration(node: Node, errorNode?: Node): void {
             if (node.kind === SyntaxKind.TypeParameter || node.kind === SyntaxKind.Parameter) {
                 return;

src/compiler/diagnosticInformationMap.generated.ts

@@ -429,16 +429,22 @@ namespace ts {
         Implements_clause_references_inaccessible_name_0: { code: 4019, category: DiagnosticCategory.Error, key: "Implements clause references inaccessible name '{0}'." },
         Extends_clause_references_inaccessible_name_0: { code: 4020, category: DiagnosticCategory.Error, key: "Extends clause references inaccessible name '{0}'." },
         Type_of_variable_0_references_inaccessible_name_1: { code: 4025, category: DiagnosticCategory.Error, key: "Type of variable '{0}' references inaccessible name '{1}'." },
+        Name_of_inferred_type_of_variable_0_could_not_be_written_Consider_adding_an_explicit_type_annotation: { code: 4026, category: DiagnosticCategory.Error, key: "Name of inferred type of variable '{0}' could not be written. Consider adding an explicit type annotation." },
         Type_of_property_0_references_inaccessible_name_1: { code: 4028, category: DiagnosticCategory.Error, key: "Type of property '{0}' references inaccessible name '{1}'." },
-        Type_of_parameter_0_references_inaccessible_name_1: { code: 4028, category: DiagnosticCategory.Error, key: "Type of parameter '{0}' references inaccessible name '{1}'." },
+        Name_of_inferred_type_of_property_0_could_not_be_written_Consider_adding_an_explicit_type_annotation: { code: 4029, category: DiagnosticCategory.Error, key: "Name of inferred type of property '{0}' could not be written. Consider adding an explicit type annotation." },
+        Type_of_parameter_0_references_inaccessible_name_1: { code: 4030, category: DiagnosticCategory.Error, key: "Type of parameter '{0}' references inaccessible name '{1}'." },
+        Name_of_inferred_type_of_parameter_0_could_not_be_written_Consider_adding_an_explicit_type_annotation: { code: 4031, category: DiagnosticCategory.Error, key: "Name of inferred type of parameter '{0}' could not be written. Consider adding an explicit type annotation." },
         Return_type_of_method_0_references_inaccessible_name_1: { code: 4038, category: DiagnosticCategory.Error, key: "Return type of method '{0}' references inaccessible name '{1}'." },
+        Name_of_inferred_return_type_of_method_0_could_not_be_written_Consider_adding_an_explicit_type_annotation: { code: 4039, category: DiagnosticCategory.Error, key: "Name of inferred return type of method '{0}' could not be written. Consider adding an explicit type annotation." },
         Return_type_of_property_getter_0_references_inaccessible_name_1: { code: 4043, category: DiagnosticCategory.Error, key: "Return type of property getter '{0}' references inaccessible name '{1}'." },
         Return_type_of_construct_signature_references_inaccessible_name_0: { code: 4044, category: DiagnosticCategory.Error, key: "Return type of construct signature references inaccessible name '{0}'." },
         Return_type_of_call_signature_references_inaccessible_name_0: { code: 4047, category: DiagnosticCategory.Error, key: "Return type of call signature references inaccessible name '{0}'." },
         Return_type_of_index_signature_references_inaccessible_name_0: { code: 4049, category: DiagnosticCategory.Error, key: "Return type of index signature references inaccessible name '{0}'." },
         Return_type_of_function_0_references_inaccessible_name_1: { code: 4060, category: DiagnosticCategory.Error, key: "Return type of function '{0}' references inaccessible name '{1}'." },
+        Name_of_inferred_return_type_of_function_0_could_not_be_written_Consider_adding_an_explicit_type_annotation: { code: 4061, category: DiagnosticCategory.Error, key: "Name of inferred return type of function '{0}' could not be written. Consider adding an explicit type annotation." },
         Type_alias_0_references_inaccessible_name_1: { code: 4081, category: DiagnosticCategory.Error, key: "Type alias '{0}' references inaccessible name '{1}'." },
         Default_export_of_the_module_references_inaccessible_name_0: { code: 4082, category: DiagnosticCategory.Error, key: "Default export of the module references inaccessible name '{0}'." },
+        Name_of_inferred_type_of_default_export_could_not_be_written_Consider_exporting_a_declaration_instead: { code: 4083, category: DiagnosticCategory.Error, key: "Name of inferred type of default export could not be written. Consider exporting a declaration instead." },
         Loop_contains_block_scoped_variable_0_referenced_by_a_function_in_the_loop_This_is_only_supported_in_ECMAScript_6_or_higher: { code: 4091, category: DiagnosticCategory.Error, key: "Loop contains block-scoped variable '{0}' referenced by a function in the loop. This is only supported in ECMAScript 6 or higher." },
         The_current_host_does_not_support_the_0_option: { code: 5001, category: DiagnosticCategory.Error, key: "The current host does not support the '{0}' option." },
         Cannot_find_the_common_subdirectory_path_for_the_input_files: { code: 5009, category: DiagnosticCategory.Error, key: "Cannot find the common subdirectory path for the input files." },

src/compiler/diagnosticMessages.json

@@ -1706,18 +1706,34 @@
         "category": "Error",
         "code": 4025
     },
+    "Name of inferred type of variable '{0}' could not be written. Consider adding an explicit type annotation.": {
+        "category": "Error",
+        "code": 4026
+    },
     "Type of property '{0}' references inaccessible name '{1}'.": {
         "category": "Error",
         "code": 4028
     },
+    "Name of inferred type of property '{0}' could not be written. Consider adding an explicit type annotation.": {
+        "category": "Error",
+        "code": 4029
+    },
     "Type of parameter '{0}' references inaccessible name '{1}'.": {
         "category": "Error",
-        "code": 4028
+        "code": 4030
+    },
+    "Name of inferred type of parameter '{0}' could not be written. Consider adding an explicit type annotation.": {
+        "category": "Error",
+        "code": 4031
     },
     "Return type of method '{0}' references inaccessible name '{1}'.": {
         "category": "Error",
         "code": 4038
     },
+    "Name of inferred return type of method '{0}' could not be written. Consider adding an explicit type annotation.": {
+        "category": "Error",
+        "code": 4039
+    },
     "Return type of property getter '{0}' references inaccessible name '{1}'.": {
         "category": "Error",
         "code": 4043
@@ -1738,6 +1754,10 @@
         "category": "Error",
         "code": 4060
     },
+    "Name of inferred return type of function '{0}' could not be written. Consider adding an explicit type annotation.": {
+        "category": "Error",
+        "code": 4061
+    },
     "Type alias '{0}' references inaccessible name '{1}'.": {
         "category": "Error",
         "code": 4081
@@ -1746,6 +1766,11 @@
         "category": "Error",
         "code": 4082
     },
+    "Name of inferred type of default export could not be written. Consider exporting a declaration instead.": {
+        "category": "Error",
+        "code": 4083
+    },
+
 
     "Loop contains block-scoped variable '{0}' referenced by a function in the loop. This is only supported in ECMAScript 6 or higher.": {
         "category": "Error",

src/compiler/types.ts

@@ -1471,6 +1471,7 @@ namespace ts {
         // declaration emitter to help determine if it should patch up the final declaration file
         // with import statements it previously saw (but chose not to emit).
         trackSymbol(symbol: Symbol, enclosingDeclaration?: Node, meaning?: SymbolFlags): void;
+        trackInaccesibleSymbol(symbol: Symbol): void;
     }
 
     export const enum TypeFormatFlags {
@@ -1786,10 +1787,10 @@ namespace ts {
         StringLike = String | StringLiteral,
         NumberLike = Number | Enum,
         ObjectType = Class | Interface | Reference | Tuple | Anonymous,
-        UnionOrIntersection = Union | Intersection,
+        UnionOrIntersection = Union | Intersection,
         StructuredType = ObjectType | Union | Intersection,
         /* @internal */
-        RequiresWidening = ContainsUndefinedOrNull | ContainsObjectLiteral
+        RequiresWidening = ContainsUndefinedOrNull | ContainsObjectLiteral
     }
 
     // Properties common to all types

src/compiler/utilities.ts

@@ -64,7 +64,8 @@ namespace ts {
                 increaseIndent: () => { },
                 decreaseIndent: () => { },
                 clear: () => str = "",
-                trackSymbol: () => { }
+                trackSymbol: () => { },
+                trackInaccesibleSymbol: () => { }
             };
         }
 

src/services/utilities.ts

@@ -528,7 +528,8 @@ namespace ts {
             increaseIndent: () => { indent++; },
             decreaseIndent: () => { indent--; },
             clear: resetWriter,
-            trackSymbol: () => { }
+            trackSymbol: () => { },
+            trackInaccesibleSymbol: () => { }
         };
 
         function writeIndent() {

tests/baselines/reference/declFileTypeAnnotationVisibilityErrorAccessors.errors.txt

@@ -1,12 +1,12 @@
 tests/cases/compiler/declFileTypeAnnotationVisibilityErrorAccessors.ts(16,21): error TS4043: Return type of property getter 'foo1' references inaccessible name 'private1'.
 tests/cases/compiler/declFileTypeAnnotationVisibilityErrorAccessors.ts(21,13): error TS4043: Return type of property getter 'foo2' references inaccessible name 'private1'.
-tests/cases/compiler/declFileTypeAnnotationVisibilityErrorAccessors.ts(26,25): error TS4028: Type of parameter 'param' references inaccessible name 'private1'.
-tests/cases/compiler/declFileTypeAnnotationVisibilityErrorAccessors.ts(33,25): error TS4028: Type of parameter 'param' references inaccessible name 'private1'.
+tests/cases/compiler/declFileTypeAnnotationVisibilityErrorAccessors.ts(26,25): error TS4030: Type of parameter 'param' references inaccessible name 'private1'.
+tests/cases/compiler/declFileTypeAnnotationVisibilityErrorAccessors.ts(33,25): error TS4030: Type of parameter 'param' references inaccessible name 'private1'.
 tests/cases/compiler/declFileTypeAnnotationVisibilityErrorAccessors.ts(37,21): error TS4043: Return type of property getter 'foo5' references inaccessible name 'private1'.
 tests/cases/compiler/declFileTypeAnnotationVisibilityErrorAccessors.ts(72,23): error TS4043: Return type of property getter 'foo111' references inaccessible name 'm2'.
 tests/cases/compiler/declFileTypeAnnotationVisibilityErrorAccessors.ts(77,13): error TS4043: Return type of property getter 'foo112' references inaccessible name 'm2'.
-tests/cases/compiler/declFileTypeAnnotationVisibilityErrorAccessors.ts(82,27): error TS4028: Type of parameter 'param' references inaccessible name 'm2'.
-tests/cases/compiler/declFileTypeAnnotationVisibilityErrorAccessors.ts(89,27): error TS4028: Type of parameter 'param' references inaccessible name 'm2'.
+tests/cases/compiler/declFileTypeAnnotationVisibilityErrorAccessors.ts(82,27): error TS4030: Type of parameter 'param' references inaccessible name 'm2'.
+tests/cases/compiler/declFileTypeAnnotationVisibilityErrorAccessors.ts(89,27): error TS4030: Type of parameter 'param' references inaccessible name 'm2'.
 tests/cases/compiler/declFileTypeAnnotationVisibilityErrorAccessors.ts(93,23): error TS4043: Return type of property getter 'foo115' references inaccessible name 'm2'.
 
 
@@ -42,7 +42,7 @@ tests/cases/compiler/declFileTypeAnnotationVisibilityErrorAccessors.ts(93,23): e
             // setter with annotation
             set foo3(param: private1) {
                             ~~~~~~~~
-!!! error TS4028: Type of parameter 'param' references inaccessible name 'private1'.
+!!! error TS4030: Type of parameter 'param' references inaccessible name 'private1'.
             }
 
             // Both - getter without annotation, setter with annotation
@@ -51,7 +51,7 @@ tests/cases/compiler/declFileTypeAnnotationVisibilityErrorAccessors.ts(93,23): e
             }
             set foo4(param: private1) {
                             ~~~~~~~~
-!!! error TS4028: Type of parameter 'param' references inaccessible name 'private1'.
+!!! error TS4030: Type of parameter 'param' references inaccessible name 'private1'.
             }
 
             // Both - with annotation
@@ -108,7 +108,7 @@ tests/cases/compiler/declFileTypeAnnotationVisibilityErrorAccessors.ts(93,23): e
             // setter with annotation
             set foo113(param: m2.public2) {
                               ~~
-!!! error TS4028: Type of parameter 'param' references inaccessible name 'm2'.
+!!! error TS4030: Type of parameter 'param' references inaccessible name 'm2'.
             }
 
             // Both - getter without annotation, setter with annotation
@@ -117,7 +117,7 @@ tests/cases/compiler/declFileTypeAnnotationVisibilityErrorAccessors.ts(93,23): e
             }
             set foo114(param: m2.public2) {
                               ~~
-!!! error TS4028: Type of parameter 'param' references inaccessible name 'm2'.
+!!! error TS4030: Type of parameter 'param' references inaccessible name 'm2'.
             }
 
             // Both - with annotation