Fix auto import crash on weird JS aliasing #46490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
For Backlog Bug
|
@typescript-bot perf test this |
|
Heya @andrewbranch, I've started to run the perf test suite on this PR at fbf8470. You can monitor the build here. Update: The results are in! |
sandersn
approved these changes
Oct 22, 2021
| } | ||
|
|
||
| function isNamedMember(member: Symbol, escapedName: __String) { | ||
| return !isReservedMemberName(escapedName) && symbolIsValue(member); |
There was a problem hiding this comment.
what does symbolIsValue do, and how is it useful here?
There was a problem hiding this comment.
It just checks symbol.flags & SymbolFlags.Value, and it’s used to filter out type and uninstantiated namespace members out of instantiated namespaces. (I just moved this existing logic into a function so I could reuse it.)
| } | ||
| }); | ||
| const exportEquals = resolveExternalModuleSymbol(moduleSymbol); | ||
| if (exportEquals !== moduleSymbol) { |
There was a problem hiding this comment.
is forEachExportAndPropertyOfModule only used in the services layer?
| // 3. Otherwise, we have a default/namespace import that can be imported by any name, and | ||
| // `symbolTableKey` will be something undesirable like `export=` or `default`, so we try to | ||
| // get a better name. | ||
| const importedName = exportKind === ExportKind.Named || isExternalModuleSymbol(namedSymbol) |
There was a problem hiding this comment.
this is fine, but it feels a little backward compared to the usual approach of checking for special names first
There was a problem hiding this comment.
I probably agree—this is a refactor of a refactor of a refactor of... it has probably accumulated some unnecessary roundabout logic that could be simplified if rewritten fresh.
|
@andrewbranch Here they are:Comparison Report - main..46490
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
mprobst
pushed a commit
to mprobst/TypeScript
that referenced
this pull request
Jan 10, 2022
* Fix auto import crash on weird JS aliasing * Comment up the weird test * Fix setting members on union/intersection type, happens later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46024
Also probably fixes #38071 with the missing
checker.getMergedSymbolSide note: the distinction between a type’s
membersandproperties(orresolvedPropertiesin the case of a union/intersection type) is frustrating—memberscontains crucial information thatpropertieslacks, which is the key in the symbol table where that symbol is stored. It’s usually justsymbol.escapedName, but not always, as in this test case: the type of theexport=symbol has a key nameddefaults, but the symbol at that location has the namenewDefaults. (This weirdness may only happen in JS code where we jump through weird hoops to bind everything we can, not sure.) But thepropertiesarray also has filtered out the non-value symbols and symbols with reserved names (specifyingunique symboland#privatemembers), somembersis not a drop-in replacement. That said, this filtering appears to be very cheap, so I really wonder if storingpropertiesalongsidemembersis even worth the weight of the array allocations. Might be an interesting experiment.