Instead of maintaining cache id etc, reset the "working" exports map cache. #48579
Conversation
typescript-bot
added
Author: Team
For Uncommitted Bug
|
@amcasey can you check if this is helpful? |
|
My notes from the time: #45283 |
sheetalkamat
force-pushed
the
exportsCache
branch
2 times, most recently
from
6ae2684 to
b83b4ad
Compare
| BuilderState.updateSignaturesFromCache(state, state.currentAffectedFilesSignatures!); | ||
| state.currentAffectedFilesSignatures!.clear(); | ||
| BuilderState.updateExportedFilesMapFromCache(state, state.currentAffectedFilesExportedModulesMap); | ||
| state.currentAffectedFilesExportedModulesMap?.clear(); |
There was a problem hiding this comment.
I think this got missed when we first introduced currentAffectedFilesExportedModulesMap.. Look how we clear currentAffectedFilesSignatures just above..
This reverts commit 0f6e6ef.
…to final exports map
sheetalkamat
force-pushed
the
exportsCache
branch
from
b83b4ad to
3ac9226
Compare
|
As I mentioned offline, I think we need to confirm this doesn't cause a real-world regression. I'm trying to get set up to validate that now. |
|
Edit: I should probably try a project mode build, just in case. |
amcasey
left a comment
amcasey
left a comment
There was a problem hiding this comment.
Perf looks comparable on the project that motivated the change.
…cache. (microsoft#48579) * Revert "Avoid no-op export map updates (microsoft#45238)" This reverts commit 0f6e6ef. * Need to reset currentAffectedFilesExportedModulesMap after commiting to final exports map
Is this better alternative to #45238