Skip to content

Add support for completions inside string literals #8428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhegazy merged 12 commits into from
Jun 8, 2016
Merged

Add support for completions inside string literals #8428

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
21587aa
Rewrite isInStringLiteral to accomodate for unterminated strings
mhegazy May 2, 2016
0a277a1
Refactor signatureHelp to expose helper functions
mhegazy May 2, 2016
060f2a8
Add support for completion in string literals
mhegazy May 2, 2016
7b0d664
Remove unused check
mhegazy May 2, 2016
4464a41
Merge branch 'master' into stringLiteralCompletions
mhegazy May 3, 2016
291ad33
Use const instead of let
mhegazy May 3, 2016
e5a32b7
Fix error
mhegazy May 3, 2016
02f30ff
Formatting changes
mhegazy May 3, 2016
b9ab4d3
Use shorthand properties
mhegazy May 3, 2016
f657e3c
Merge branch 'master' into stringLiteralCompletions
mhegazy May 8, 2016
9027da4
Merge branch 'master' into stringLiteralCompletions
mhegazy Jun 8, 2016
cc5dd5b
Add comments
mhegazy Jun 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unused check
  • Loading branch information
@mhegazy
mhegazy committed May 2, 2016
commit 7b0d664394c3a3742e6c52d9fec65e3f3e445267
1 change: 0 additions & 1 deletion src/services/services.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4061,7 +4061,6 @@ namespace ts {
return undefined;
}

isNameOfExternalModuleImportOrDeclaration
const argumentInfo = SignatureHelp.getContainingArgumentInfo(node, position, sourceFile);
Copy link
Member

@DanielRosenwasser DanielRosenwasser May 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a slightly weird sort of dependency. Ideally there would be an API on the type checker like getPossibleContextualTypes

Copy link
Contributor Author

@mhegazy mhegazy May 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not contextual type per se. but sure. If there is another use case for such API we can push it into the checker, but this is the only one, i would keep it at the use site.

if (argumentInfo) {
Copy link
Contributor

@yuit yuit May 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: could you add comments from the PR description here. so we know what cases are covered

Copy link
Contributor Author

@mhegazy mhegazy May 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure.

return getStringLiteralCompletionEntriesFromCallExpression(argumentInfo);
Expand Down