Skip to content

[Release-2.0] Fix 9662: Visual Studio 2015 with TS2.0 gives incorrect @types path resolution errors #9867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuit merged 9 commits into from
Aug 4, 2016
Merged

[Release-2.0] Fix 9662: Visual Studio 2015 with TS2.0 gives incorrect @types path resolution errors #9867

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
eb055b1
Change the shape of the shim layer to support getAutomaticTypeDirectives
Jul 21, 2016
11e3821
Change the key for looking up automatic type-directives
Jul 21, 2016
c463808
Update baselines from change look-up name of type-directives
Jul 21, 2016
b269ab9
Merge branch 'master' into fix9662_onlyScriptSide
Jul 21, 2016
f949e0e
Add @currentDirectory into the test
Jul 25, 2016
6f3cf9a
Update baselines
Jul 25, 2016
502b036
Fix linting error
Jul 25, 2016
4c1829f
Address PR: fix spelling mistake
Jul 26, 2016
5ee16bf
Instead of return path of the type directive names just return type d…
Jul 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change the key for looking up automatic type-directives
  • Loading branch information
Kanchalai Tanglertsampan committed Jul 21, 2016
commit 11e3821c3329919f0a7b30c2af8bae378ae9ab5a
4 changes: 2 additions & 2 deletions src/compiler/program.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1158,8 +1158,8 @@ namespace ts {
const typeReferences: string[] = getAutomaticTypeDirectiveNames(options, host);

if (typeReferences) {
const inferredRoot = getInferredTypesRoot(options, rootNames, host);
const containingFilename = combinePaths(inferredRoot, "__inferred type names__.ts");
// This containgFilename needs to matched with the one used in managed-side
Copy link

@giannic giannic Jul 26, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: matched -> match and containgFilename -> containingFilename

const containingFilename = "__inferred type names__.ts"
Copy link
Contributor

@vladima vladima Jul 21, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it work in VSCode? since this name is now always relative

Copy link
Contributor Author

@yuit yuit Jul 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From talking off line, this is incorrect as it will not be unique to the project of interest. IT will be problematic if more than one project is open. The fix is to use host.getCurrentDirectory()

const resolutions = resolveTypeReferenceDirectiveNamesWorker(typeReferences, containingFilename);
for (let i = 0; i < typeReferences.length; i++) {
processTypeReferenceDirective(typeReferences[i], resolutions[i]);
Expand Down