Skip to content

JSDoc string literal types #9995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sandersn merged 7 commits into from
Aug 17, 2016
Merged

JSDoc string literal types #9995

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a6642d6
JSDoc understands string literal types
sandersn Jul 27, 2016
6fbd79b
Update baselines to be current
sandersn Jul 27, 2016
5c2ba01
Update baseline source location
sandersn Jul 27, 2016
f8103b5
Update LastJSDoc[Tag]Node
sandersn Jul 27, 2016
e5973b8
Add string-literal completion test for jsdoc
sandersn Aug 4, 2016
4c35296
Merge branch 'master' into jsdoc-string-literal-types
sandersn Aug 4, 2016
3c32478
Support other (new) literal types in jsdoc
sandersn Aug 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update baselines to be current
  • Loading branch information
@sandersn
sandersn committed Jul 27, 2016
commit 6fbd79b70954682f8a131a4899f8a227237e91f5
18 changes: 12 additions & 6 deletions tests/baselines/reference/jsdocStringLiteral.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,22 @@
//// [in.js]
/**
* @param {'literal'} input
* @param {'literal'} p1
* @param {"literal"} p2
* @param {'literal' | 'other'} p3
* @param {'literal' | number} p4
*/
function f(input) {
return input + '.';
function f(p1, p2, p3, p4) {
return p1 + p2 + p3 + p4 + '.';
}


//// [out.js]
/**
* @param {'literal'} input
* @param {'literal'} p1
* @param {"literal"} p2
* @param {'literal' | 'other'} p3
* @param {'literal' | number} p4
*/
function f(input) {
return input + '.';
function f(p1, p2, p3, p4) {
return p1 + p2 + p3 + p4 + '.';
}
19 changes: 14 additions & 5 deletions tests/baselines/reference/jsdocStringLiteral.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,21 @@
=== tests/cases/compiler/in.js ===
/**
* @param {'literal'} input
* @param {'literal'} p1
* @param {"literal"} p2
* @param {'literal' | 'other'} p3
* @param {'literal' | number} p4
*/
function f(input) {
function f(p1, p2, p3, p4) {
>f : Symbol(f, Decl(in.js, 0, 0))
>input : Symbol(input, Decl(in.js, 3, 11))
>p1 : Symbol(p1, Decl(in.js, 6, 11))
>p2 : Symbol(p2, Decl(in.js, 6, 14))
>p3 : Symbol(p3, Decl(in.js, 6, 18))
>p4 : Symbol(p4, Decl(in.js, 6, 22))

return input + '.';
>input : Symbol(input, Decl(in.js, 3, 11))
return p1 + p2 + p3 + p4 + '.';
>p1 : Symbol(p1, Decl(in.js, 6, 11))
>p2 : Symbol(p2, Decl(in.js, 6, 14))
>p3 : Symbol(p3, Decl(in.js, 6, 18))
>p4 : Symbol(p4, Decl(in.js, 6, 22))
}

26 changes: 19 additions & 7 deletions tests/baselines/reference/jsdocStringLiteral.types
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,26 @@
=== tests/cases/compiler/in.js ===
/**
* @param {'literal'} input
* @param {'literal'} p1
* @param {"literal"} p2
* @param {'literal' | 'other'} p3
* @param {'literal' | number} p4
*/
function f(input) {
>f : (input: "literal") => string
>input : "literal"
function f(p1, p2, p3, p4) {
>f : (p1: "literal", p2: "literal", p3: "literal" | "other", p4: "literal" | number) => string
>p1 : "literal"
>p2 : "literal"
>p3 : "literal" | "other"
>p4 : "literal" | number

return input + '.';
>input + '.' : string
>input : "literal"
return p1 + p2 + p3 + p4 + '.';
>p1 + p2 + p3 + p4 + '.' : string
>p1 + p2 + p3 + p4 : string
>p1 + p2 + p3 : string
>p1 + p2 : string
>p1 : "literal"
>p2 : "literal"
>p3 : "literal" | "other"
>p4 : "literal" | number
>'.' : string
}