-
Notifications
You must be signed in to change notification settings - Fork 882
Refactor templates into single template groups that allow you select TFM and aspire version #6365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
47621fb
Refactor templates into a single template with TFM & Aspire version c…
DamianEdwards cb359b9
PR feedback
DamianEdwards ee6fdd0
PR feedback
DamianEdwards 220fbe0
First round of test fixup
DamianEdwards bfb42c1
Add support for moving template tests created projects to custom temp…
DamianEdwards b82117a
Merge branch 'main' into damianedwards/single-templates
DamianEdwards ea02bf8
Fix bootstrap CSS link in starter template
DamianEdwards File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 0 additions & 35 deletions
35
....ProjectTemplates/templates/aspire-apphost-downlevel/.template.config/dotnetcli.host.json
This file was deleted.
Oops, something went wrong.
12 changes: 0 additions & 12 deletions
12
...Aspire.ProjectTemplates/templates/aspire-apphost-downlevel/.template.config/ide.host.json
This file was deleted.
Oops, something went wrong.
Binary file removed
BIN
-54.8 KB
...rojectTemplates/templates/aspire-apphost-downlevel/.template.config/ide/AspireAppHost.ico
Binary file not shown.
18 changes: 0 additions & 18 deletions
18
...ates/templates/aspire-apphost-downlevel/.template.config/localize/templatestrings.cs.json
This file was deleted.
Oops, something went wrong.
18 changes: 0 additions & 18 deletions
18
...ates/templates/aspire-apphost-downlevel/.template.config/localize/templatestrings.de.json
This file was deleted.
Oops, something went wrong.
18 changes: 0 additions & 18 deletions
18
...ates/templates/aspire-apphost-downlevel/.template.config/localize/templatestrings.en.json
This file was deleted.
Oops, something went wrong.
18 changes: 0 additions & 18 deletions
18
...ates/templates/aspire-apphost-downlevel/.template.config/localize/templatestrings.es.json
This file was deleted.
Oops, something went wrong.
18 changes: 0 additions & 18 deletions
18
...ates/templates/aspire-apphost-downlevel/.template.config/localize/templatestrings.fr.json
This file was deleted.
Oops, something went wrong.
18 changes: 0 additions & 18 deletions
18
...ates/templates/aspire-apphost-downlevel/.template.config/localize/templatestrings.it.json
This file was deleted.
Oops, something went wrong.
18 changes: 0 additions & 18 deletions
18
...ates/templates/aspire-apphost-downlevel/.template.config/localize/templatestrings.ja.json
This file was deleted.
Oops, something went wrong.
18 changes: 0 additions & 18 deletions
18
...ates/templates/aspire-apphost-downlevel/.template.config/localize/templatestrings.ko.json
This file was deleted.
Oops, something went wrong.
18 changes: 0 additions & 18 deletions
18
...ates/templates/aspire-apphost-downlevel/.template.config/localize/templatestrings.pl.json
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that
Microsoft.Extensions.Http.Resilienceis on a "tip support" policy. Meaning that only the latest version is supported. (I think there maybe a nuance here where the8.0version is LTS, but I can't seem to find the public policy.)Given the above, I think we should always be referencing the current/latest version of
Microsoft.Extensions.Http.Resiliencefrom our templates regardless of TFM chosen. Even if you are targetingnet8.0, we would bring in the 9.0 version ofMicrosoft.Extensions.Http.Resilience.See also: Use 8.0 era dependencies for non net9.0 TFMs (dotnet/extensions#5470)
cc @joperezr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't our repo be using the 9.x version then too? Currently it's using the 8.x version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. That's part of this as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I hold off on a change here until we get consensus?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is an agreement here. As @eerhardt points out, we want to use the tip of this package both in net8 and net9. There is still the PR that he pointed out above which hasn't been merged but will be merged before 9.0 ships.