Skip to content

Enable devcontainers in repo. #6491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchdenny merged 16 commits into from
Oct 29, 2024
Merged

Enable devcontainers in repo. #6491

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
fc560d3
DevContainer initial commit.
mitchdenny Oct 25, 2024
956663b
WIP
mitchdenny Oct 25, 2024
6afb544
WIP: devcontainer walkthrough.
mitchdenny Oct 25, 2024
0637d5e
Changes.
mitchdenny Oct 25, 2024
51e8389
Set host requirements.
mitchdenny Oct 28, 2024
91ea30d
Fix codespace test so it can run under codespaces.
mitchdenny Oct 28, 2024
56fa242
Introduce Codespaces options.
mitchdenny Oct 28, 2024
c87e7d9
Map Redis playground ports.
mitchdenny Oct 28, 2024
b23ccb1
Update src/Aspire.Hosting/Codespaces/CodespacesOptions.cs
mitchdenny Oct 28, 2024
d3ff895
Update src/Aspire.Hosting/Codespaces/CodespacesOptions.cs
mitchdenny Oct 28, 2024
b0edc56
Update src/Aspire.Hosting/Codespaces/CodespacesOptions.cs
mitchdenny Oct 28, 2024
5bde6d6
Update src/Aspire.Hosting/Codespaces/CodespacesOptions.cs
mitchdenny Oct 28, 2024
b1f3fdb
Update src/Aspire.Hosting/Codespaces/CodespacesOptions.cs
mitchdenny Oct 29, 2024
8ae2a44
Change when command runs to improve reliability.
mitchdenny Oct 29, 2024
ec128aa
Syntax error.
mitchdenny Oct 29, 2024
c96a2a0
Remove public API.
mitchdenny Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/Aspire.Hosting/Codespaces/CodespacesOptions.cs 
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
  • Loading branch information
@mitchdenny @eerhardt
mitchdenny and eerhardt authored Oct 28, 2024
commit b0edc56098168c659cfb3173f4c178fc27ffcaa7
2 changes: 1 addition & 1 deletion src/Aspire.Hosting/Codespaces/CodespacesOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public class CodespacesOptions
/// Maps to the CODESPACE_NAME environment variable.
/// </remarks>
[MemberNotNullWhenAttribute(true, nameof(IsCodespace))]
Comment thread
mitchdenny marked this conversation as resolved.
Outdated
public string? CodespaceName { get; set; } = null;
public string? CodespaceName { get; set; };
}

internal class ConfigureCodespacesOptions(IConfiguration configuration) : IConfigureOptions<CodespacesOptions>
Expand Down