Skip to content

Add support for retrieving HTTP version of a request in HTTP listener #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 24, 2018
Merged

Add support for retrieving HTTP version of a request in HTTP listener #565

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f8b50f9
Grab HTTP protocol version from the underlying request message and ex…
garethsb Oct 17, 2017
dff7a1c
Use error_code overload to resolve https://github.com/Microsoft/cppre…
garethsb Oct 19, 2017
1ba5ebf
Rename get_http_version and get_remote_address without 'get_' prefix …
garethsb Oct 19, 2017
85e0450
Add test case for http_version
garethsb Oct 19, 2017
bc71f40
Fix GCC "error: changes meaning of 'http_version'..." that should hav…
garethsb Nov 9, 2017
1d35847
Use struct for http_version instead of pair.
ras0219-msft Jan 24, 2018
154e322
Restore get_remote_address to avoid breaking source compat
ras0219-msft Jan 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename get_http_version and get_remote_address without 'get_' prefix … 
…for consistency with rest of class public interface
  • Loading branch information
@garethsb
garethsb committed Oct 24, 2017
commit 1ba5ebfdb2d71d97938ecb6956a6b5bb94295794
4 changes: 2 additions & 2 deletions Release/include/cpprest/http_msg.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,13 +901,13 @@ class http_request
/// Returns the HTTP protocol version of this request message.
/// </summary>
/// <returns>The HTTP protocol version.</returns>
const http_version& get_http_version() const { return _m_impl->http_version(); }
const http_version& http_version() const { return _m_impl->http_version(); }

/// <summary>
/// Returns a string representation of the remote IP address.
/// </summary>
/// <returns>The remote IP address.</returns>
const utility::string_t& get_remote_address() const { return _m_impl->remote_address(); }
const utility::string_t& remote_address() const { return _m_impl->remote_address(); }

/// <summary>
/// Extract the body of the request message as a string value, checking that the content type is a MIME text type.
Expand Down
2 changes: 1 addition & 1 deletion Release/tests/functional/http/listener/request_handler_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ TEST_FIXTURE(uri_address, remote_address)

listener.support(methods::GET, [&requestCount](http_request request)
{
const string_t& remoteAddr = request.get_remote_address();
const string_t& remoteAddr = request.remote_address();
const string_t& localhost4 = string_t(U("127.0.0.1"));
const string_t& localhost6 = string_t(U("::1"));

Expand Down