Skip to content

Making crossplat::threadpool::shared_instance() safe to use in cpprest DLL #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 24, 2018
Merged

Making crossplat::threadpool::shared_instance() safe to use in cpprest DLL #611

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f250c4c
When the C++ REST SDK is built as a DLL on Windows, and unloaded befo…
garethsb Nov 24, 2017
01d5c19
Take 2. We can't just use TerminateThread indiscriminately because th…
garethsb Nov 27, 2017
9da20ab
Export the shared instance to allow cross-platform implementation of …
garethsb Dec 15, 2017
e7566e2
Use improved shutdown logic even when building as static lib, because…
ras0219-msft Jan 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Export the shared instance to allow cross-platform implementation of … 
…functionality (e.g. complete_after) that needs access to the io_service when using the asio-based default scheduler
  • Loading branch information
@garethsb
garethsb committed Dec 15, 2017
commit 9da20abfac1facb68752e52c3c69ff41506a2f1f
2 changes: 1 addition & 1 deletion Release/include/pplx/threadpool.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ using java_local_ref = std::unique_ptr<typename std::remove_pointer<T>::type, ja
class threadpool
{
public:
static threadpool& shared_instance();
_ASYNCRTIMP static threadpool& shared_instance();
_ASYNCRTIMP static std::unique_ptr<threadpool> __cdecl construct(size_t num_threads);

virtual ~threadpool() = default;
Expand Down