Skip to content

Conversation

@BillyONeal
Copy link
Member

No description provided.

@c72578
Copy link
Contributor

c72578 commented Oct 26, 2018

This concerns changelog.md:
The version of checked in websocketpp was 0.5.1 before deletion [1] and the "s" should be removed inside websocketpp:

  • websocketspp checked in 0.7.0 version has been changed to a submodule and updated to 0.8.1.
    ->
  • websocketpp checked in 0.5.1 version has been changed to a submodule and updated to 0.8.1.

[1] https://github.com/Microsoft/cpprestsdk/blob/9c8e0d41fb6e27acb2ae0edbd08022b392c2a33c/Release/libs/websocketpp/websocketpp/version.hpp

@BillyONeal
Copy link
Member Author

@c72578 Thanks, I must have been confused with the version apt and/or brew and/or vcpkg were installing. Will fix!

Copy link
Contributor

@c72578 c72578 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spelling of websocketpp should be corrected in changelog.md (without "s"):
websocketspp -> websocketpp

@BillyONeal BillyONeal merged commit c4cef12 into microsoft:master Oct 31, 2018
@BillyONeal BillyONeal deleted the bump_version branch November 3, 2018 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants