Skip to content

[AppBar] Fix regression with icon active color #2318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vnbaaij merged 3 commits into from
Jul 4, 2024
Merged

[AppBar] Fix regression with icon active color #2318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27b4a20
AppBar address Aspire regression
vnbaaij Jul 3, 2024
bc4d7d4
Update WhatsNew
vnbaaij Jul 3, 2024
5483fa8
Merge branch 'dev' into users-vnbaaij/fix-appbar-regression
dvoituron Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion WHATSNEW.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
- [Demo] Fixes link for Time picker in demo projects ([#2246](https://github.com/microsoft/fluentui-blazor/pull/2246))

### Components
- [Rating] **New component** ([#2258](https://github.com/microsoft/fluentui-blazor/pull/2258))
- [AppBar] Fix regression with icon accent color ([#2318](https://github.com/microsoft/fluentui-blazor/pull/2318))
- [Autocomplete] Accessibility: Scrolling not working with keyboard ([#2221](https://github.com/microsoft/fluentui-blazor/pull/2221))
- [AutoComplete] Allow focusable Badge dismiss buttons (accessibility) ([#2272](https://github.com/microsoft/fluentui-blazor/pull/2272))
- [Autocomplete] Fix AriaLabel ([#2303](https://github.com/microsoft/fluentui-blazor/pull/2303))
Expand All @@ -35,7 +37,6 @@
- [NumberField] Add sbyte type ([#2308](https://github.com/microsoft/fluentui-blazor/pull/2308))
- [Overflow] Add refresh method, add VisibleOnLoad parameter ([#2236](https://github.com/microsoft/fluentui-blazor/pull/2236))
- [ProfileMenu] Fix the initials inner the popup panel ([#2294](https://github.com/microsoft/fluentui-blazor/pull/2294))
- [Rating] **New component** ([#2258](https://github.com/microsoft/fluentui-blazor/pull/2258))
- [Slider] Fix getting caught in update loop ([#2265](https://github.com/microsoft/fluentui-blazor/pull/2265))
- [Slider] Refactor code after PR #2265 ([#2287](https://github.com/microsoft/fluentui-blazor/pull/2287))
- [TimePicker] Add null check for empty string ([#2245](https://github.com/microsoft/fluentui-blazor/pull/2245))
Expand Down
3 changes: 2 additions & 1 deletion examples/Demo/Shared/wwwroot/docs/WhatsNew.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
- [Demo] Fixes link for Time picker in demo projects ([#2246](https://github.com/microsoft/fluentui-blazor/pull/2246))

### Components
- [Rating] **New component** ([#2258](https://github.com/microsoft/fluentui-blazor/pull/2258))
- [AppBar] Fix regression with icon accent color ([#2318](https://github.com/microsoft/fluentui-blazor/pull/2318))
- [Autocomplete] Accessibility: Scrolling not working with keyboard ([#2221](https://github.com/microsoft/fluentui-blazor/pull/2221))
- [AutoComplete] Allow focusable Badge dismiss buttons (accessibility) ([#2272](https://github.com/microsoft/fluentui-blazor/pull/2272))
- [Autocomplete] Fix AriaLabel ([#2303](https://github.com/microsoft/fluentui-blazor/pull/2303))
Expand All @@ -35,7 +37,6 @@
- [NumberField] Add sbyte type ([#2308](https://github.com/microsoft/fluentui-blazor/pull/2308))
- [Overflow] Add refresh method, add VisibleOnLoad parameter ([#2236](https://github.com/microsoft/fluentui-blazor/pull/2236))
- [ProfileMenu] Fix the initials inner the popup panel ([#2294](https://github.com/microsoft/fluentui-blazor/pull/2294))
- [Rating] **New component** ([#2258](https://github.com/microsoft/fluentui-blazor/pull/2258))
- [Slider] Fix getting caught in update loop ([#2265](https://github.com/microsoft/fluentui-blazor/pull/2265))
- [Slider] Refactor code after PR #2265 ([#2287](https://github.com/microsoft/fluentui-blazor/pull/2287))
- [TimePicker] Add null check for empty string ([#2245](https://github.com/microsoft/fluentui-blazor/pull/2245))
Expand Down
14 changes: 13 additions & 1 deletion src/Core/Components/AppBar/FluentAppBar.razor.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,19 @@

::deep .fluent-appbar-item:hover svg[part="icon-rest"],
::deep .fluent-appbar-item:not(:hover):not(.active) svg[part="icon-active"],
::deep .fluent-appbar-item:not(:hover).active svg[part="icon-rest"],
::deep .fluent-appbar-item:not(:hover) a.active svg[part="icon-rest"],
::deep .fluent-appbar-item[overflow] {
display: none;
}

::deep .fluent-appbar-item:not(:hover) .active svg[part="icon-active"] {
display: block;
}

::deep .fluent-appbar-item.popover:not(:hover) a.active svg[part="icon-active"] {
display: none;
}

::deep .fluent-appbar-item.popover:not(:hover) a.active svg[part="icon-rest"] {
display: block;
}