Skip to content

[SortableList] Adding Properties FromListId and ToListId #2385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dvoituron merged 11 commits into from
Jul 16, 2024
Merged

[SortableList] Adding Properties FromListId and ToListId #2385

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ad13e93
feat: allow FluentSortableList to know where an item was dragged from…
RReventlov Jul 14, 2024
dd70d48
Renamed properties
RReventlov Jul 15, 2024
874417c
Changed example back to two lists
RReventlov Jul 15, 2024
033f53e
Reverted to the previous example with added traces for the id.
RReventlov Jul 15, 2024
3c679b2
Added a test to verify the Id is added to the list
RReventlov Jul 15, 2024
87d2650
Renamed the test to clarify intent
RReventlov Jul 15, 2024
fb90e9e
Added unit test for OnUpdate
RReventlov Jul 15, 2024
e300799
Changed parameter names to reflect property names
RReventlov Jul 15, 2024
dce2aeb
Merge branch 'dev' into feat/fluentsearchablelist
dvoituron Jul 16, 2024
a6ac7c7
Reverted changes made by the IDE
RReventlov Jul 16, 2024
4503c3f
Merge branch 'dev' into feat/fluentsearchablelist
dvoituron Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Changed example back to two lists 
The swapping is still handled differently (getting the list through the ids) than before.
  • Loading branch information
@RReventlov
RReventlov committed Jul 15, 2024
commit 874417cfd7ec0831b147fbd2329a51fe0d2ec395
12 changes: 0 additions & 12 deletions examples/Demo/Shared/Pages/SortableList/Examples/SortableListMoveBetweenLists.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@
.fluent-sortable-list.darker {
--fluent-sortable-list-background-color: var(--neutral-layer-4) !important;
}
.fluent-sortable-list.lighter {
--fluent-sortable-list-background-color: var(--neutral-layer-1) !important;
}
</style>


Expand All @@ -21,12 +18,6 @@
<ItemTemplate>@item.Name</ItemTemplate>
</FluentSortableList>
</FluentGridItem>
<FluentGridItem xs="12" sm="6">
<h5>List 3</h5>
<FluentSortableList Id="shared3" Class="lighter" Group="sharedLists" OnUpdate="@HandleSort" OnRemove="@HandleRemove" Items="@items3" Context="item">
<ItemTemplate>@item.Name</ItemTemplate>
</FluentSortableList>
</FluentGridItem>
</FluentGrid>

@code {
Expand All @@ -42,8 +33,6 @@

public List<Item> items2 = Enumerable.Range(11, 10).Select(i => new Item { Id = i, Name = $"Item {i}" }).ToList();

public List<Item> items3 = Enumerable.Range(21, 10).Select(i => new Item { Id = i, Name = $"Item {i}" }).ToList();


private void HandleRemove(FluentSortableListEventArgs args)
{
Expand Down Expand Up @@ -97,7 +86,6 @@
{
"shared1" => items1,
"shared2" => items2,
"shared3" => items3,
_ => throw new ArgumentException($"No list with id {id}")
};

Expand Down