Skip to content

[Overflow] Add Fixed parameter #2393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vnbaaij merged 2 commits into from
Jul 17, 2024
Merged

[Overflow] Add Fixed parameter #2393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c4d22b
- Fix #2390 by moving logic inside popover close code
vnbaaij Jul 17, 2024
67fbacd
Merge branch 'dev' into users/vnbaaij/aspire-fixes
dvoituron Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion examples/Demo/Shared/Microsoft.FluentUI.AspNetCore.Components.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7025,6 +7025,12 @@
Gets True if this component is out of panel.
</summary>
</member>
<member name="P:Microsoft.FluentUI.AspNetCore.Components.FluentOverflowItem.Fixed">
<summary>
Gets or sets if this item dos not participates in overflow logic.
Defaults to false
</summary>
</member>
<member name="P:Microsoft.FluentUI.AspNetCore.Components.FluentOverflowItem.Text">
<summary>
Gets the InnerText of <see cref="P:Microsoft.FluentUI.AspNetCore.Components.FluentOverflowItem.ChildContent"/>.
Expand Down Expand Up @@ -7219,7 +7225,7 @@
</member>
<member name="P:Microsoft.FluentUI.AspNetCore.Components.FluentPopover.HorizontalInset">
<summary>
Gets or sets a value indicating whether the region overlaps the anchor on the horizontal axis.
Gets or sets a value indicating whether the region overlaps the anchor on the horizontal axis.
Default is true which places the region aligned with the anchor element.
</summary>
</member>
Expand Down
4 changes: 2 additions & 2 deletions src/Core/Components/Overflow/FluentOverflowItem.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@namespace Microsoft.FluentUI.AspNetCore.Components
@inherits FluentComponentBase

<div id="@Id" class="@ClassValue" style="@StyleValue" overflow=@Overflow>
<div id="@Id" class="@ClassValue" style="@StyleValue" overflow=@Overflow fixed="@(Fixed ? "fixed" : null)">
@ChildContent
</div>
</div>
7 changes: 7 additions & 0 deletions src/Core/Components/Overflow/FluentOverflowItem.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,13 @@ public partial class FluentOverflowItem : IDisposable
[Parameter]
public RenderFragment? ChildContent { get; set; }

/// <summary>
/// Gets or sets if this item dos not participates in overflow logic.
/// Defaults to false
/// </summary>
[Parameter]
public bool Fixed { get; set; } = false;

/// <summary>
/// Gets True if this component is out of panel.
/// </summary>
Expand Down
4 changes: 2 additions & 2 deletions src/Core/Components/Popover/FluentPopover.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public partial class FluentPopover : FluentComponentBase
public HorizontalPosition? HorizontalPosition { get; set; } = AspNetCore.Components.HorizontalPosition.Unset;

/// <summary>
/// Gets or sets a value indicating whether the region overlaps the anchor on the horizontal axis.
/// Gets or sets a value indicating whether the region overlaps the anchor on the horizontal axis.
/// Default is true which places the region aligned with the anchor element.
/// </summary>
[Parameter]
Expand Down Expand Up @@ -130,11 +130,11 @@ protected override void OnParametersSet()
protected virtual async Task CloseAsync()
{
Open = false;
await AnchoredRegion.FocusToOriginalElementAsync();
if (OpenChanged.HasDelegate)
{
await OpenChanged.InvokeAsync(Open);
}
await AnchoredRegion.FocusToOriginalElementAsync();
}

/// <summary />
Expand Down