Skip to content

[Checkbox] Fix looping value error when used in a Stack #2417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vnbaaij merged 7 commits into from
Aug 20, 2024
Merged

[Checkbox] Fix looping value error when used in a Stack #2417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9d9a818
Testing fix for #2356
vnbaaij Jul 19, 2024
e578074
Change bool logic
vnbaaij Jul 19, 2024
1497cca
Store
vnbaaij Jul 21, 2024
38eb5d9
Merge branch 'dev' into users/vnbaaij/fix-issue-#2356
vnbaaij Aug 20, 2024
52caf8c
Update JavaScript SDK
vnbaaij Aug 20, 2024
caab663
Add short delay
vnbaaij Aug 20, 2024
5785edc
Fix tests
vnbaaij Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/Demo/Shared/Microsoft.FluentUI.AspNetCore.Components.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8501,7 +8501,7 @@
</member>
<member name="P:Microsoft.FluentUI.AspNetCore.Components.FluentStack.HorizontalAlignment">
<summary>
Gets or sets the horizontal alignment of the components in the stack.
Gets or sets the horizontal alignment of the components in the stack.
</summary>
</member>
<member name="P:Microsoft.FluentUI.AspNetCore.Components.FluentStack.VerticalAlignment">
Expand All @@ -8511,7 +8511,7 @@
</member>
<member name="P:Microsoft.FluentUI.AspNetCore.Components.FluentStack.Orientation">
<summary>
Gets or sets the orientation of the stacked components.
Gets or sets the orientation of the stacked components.
</summary>
</member>
<member name="P:Microsoft.FluentUI.AspNetCore.Components.FluentStack.Width">
Expand Down
23 changes: 23 additions & 0 deletions examples/Demo/Shared/Pages/Lab/CheckboxBug.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
@using Microsoft.FluentUI.AspNetCore.Components
<FluentStack Orientation="Orientation.Vertical">
<FluentCheckbox Value="@Value.IsChecked"
ValueChanged="(isChecked) => ChangeDummyAsync(Value with {IsChecked = isChecked})">Checkbox</FluentCheckbox>

</FluentStack>



@code {

[Parameter, EditorRequired]
public required Dummy Value { get; set; }

[Parameter]
public EventCallback<Dummy> ValueChanged { get; set; }

private Task ChangeDummyAsync(Dummy dummy)
{
return ValueChanged.InvokeAsync(dummy);
}

}
6 changes: 6 additions & 0 deletions examples/Demo/Shared/Pages/Lab/Dummy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
// ------------------------------------------------------------------------
// MIT License - Copyright (c) Microsoft Corporation. All rights reserved.
// ------------------------------------------------------------------------

namespace FluentUI.Demo.Shared.Pages.Lab;
public record Dummy(bool IsChecked);
14 changes: 14 additions & 0 deletions examples/Demo/Shared/Pages/Lab/IssueTester.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,15 @@
@page "/issue-tester"

<FluentTabs>
<FluentTab Label="Tab1">
<CheckboxBug @bind-Value=@dummy />
</FluentTab>
</FluentTabs>


@code {

private Dummy dummy = new Dummy(false);


}
2 changes: 1 addition & 1 deletion src/Core.Assets/Microsoft.FluentUI.AspNetCore.Components.Assets.esproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.VisualStudio.JavaScript.Sdk/1.0.1327710">
<Project Sdk="Microsoft.VisualStudio.JavaScript.Sdk/1.0.1477582">
<PropertyGroup>
<DebugAssetsDirectory>dist\</DebugAssetsDirectory>
<StaticWebAssetSourceId>Microsoft.FluentUI.AspNetCore.Components</StaticWebAssetSourceId>
Expand Down
2 changes: 1 addition & 1 deletion src/Core.Assets/esbuild.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as esbuild from 'esbuild'
import pkg from './package.json' with { type: 'json' }
import pkg from './package.json' assert { type: 'json' }

await esbuild.build({
entryPoints: [ pkg.source ],
Expand Down
Loading