Skip to content

[Javascript Caching] Do not add version number to lib.module.js file #2572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vnbaaij merged 2 commits into from
Aug 22, 2024
Merged

[Javascript Caching] Do not add version number to lib.module.js file #2572

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb4cd9a
Fix #2546. Do not add version number to lib.module.js file (because t…
vnbaaij Aug 22, 2024
32bf59e
Merge branch 'dev' into users/vnbaaij/fix-issue-#2546
vnbaaij Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix #2546. Do not add version number to lib.module.js file (because t… 
…hen it will be included twice and that does funky stuff)
  • Loading branch information
@vnbaaij
vnbaaij committed Aug 22, 2024
commit bb4cd9a475f5cee1e81a04560161022a9d469167
3 changes: 1 addition & 2 deletions src/Core/DesignTokens/DesignToken.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
using System.Diagnostics.CodeAnalysis;
using Microsoft.AspNetCore.Components;
using Microsoft.FluentUI.AspNetCore.Components.Extensions;
using Microsoft.JSInterop;

namespace Microsoft.FluentUI.AspNetCore.Components.DesignTokens;
Expand Down Expand Up @@ -74,7 +73,7 @@ protected override async Task OnAfterRenderAsync(bool firstRender)

private async Task InitJSReferenceAsync()
{
_jsModule ??= await JSRuntime.InvokeAsync<IJSObjectReference>("import", JAVASCRIPT_FILE.FormatCollocatedUrl(LibraryConfiguration));
_jsModule ??= await JSRuntime.InvokeAsync<IJSObjectReference>("import", JAVASCRIPT_FILE);
}

#pragma warning disable VSTHRD200 // Use "Async" suffix for async methods
Expand Down