-
Notifications
You must be signed in to change notification settings - Fork 459
[DataGrid] Provide new way to render column actions #2586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a0027b4
Store progress
vnbaaij 4d0e4fa
Merge dev
vnbaaij 3214159
Use records for string parameter collections
vnbaaij c2133f6
Tabbing error 🤦♂️
vnbaaij bc91972
Move and change column 'label resources' records
vnbaaij 152c1c4
Process PR review comments
vnbaaij File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| @page "/issue-tester" | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
src/Core/Components/DataGrid/Columns/ColumnOptionsLabels.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| // ------------------------------------------------------------------------ | ||
| // MIT License - Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // ------------------------------------------------------------------------ | ||
| namespace Microsoft.FluentUI.AspNetCore.Components; | ||
|
|
||
| public record ColumnOptionsLabels | ||
| { | ||
| /// <summary> | ||
| /// Gets or sets the text shown in the column menu | ||
| /// </summary> | ||
| public string OptionsMenu { get; set; } = "Filter"; | ||
|
|
||
| /// <summary> | ||
| /// Gets the default labels for the options UI. | ||
| /// </summary> | ||
| public static ColumnOptionsLabels Default => new(); | ||
|
|
||
| } | ||
|
|
48 changes: 48 additions & 0 deletions
48
src/Core/Components/DataGrid/Columns/ColumnResizeLabels.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| // ------------------------------------------------------------------------ | ||
| // MIT License - Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // ------------------------------------------------------------------------ | ||
|
|
||
| namespace Microsoft.FluentUI.AspNetCore.Components; | ||
|
|
||
| public record ColumnResizeLabels | ||
| { | ||
| /// <summary> | ||
| /// Gets or sets the text shown in the column menu | ||
| /// </summary> | ||
| public string ResizeMenu { get; set; } = "Resize"; | ||
|
|
||
| /// <summary> | ||
| /// Gets or sets the label in the discrete mode resize UI | ||
| /// </summary> | ||
| public string DiscreteLabel { get; set; } = "Column width"; | ||
|
|
||
| /// <summary> | ||
| /// Gets or sets the label in the exact mode resize UI | ||
| /// </summary> | ||
| public string ExactLabel { get; set; } = "Column width (in pixels)"; | ||
|
|
||
| /// <summary> | ||
| /// Gets or sets the aria label for the grow button in the discrete resize UI | ||
| /// </summary> | ||
| public string? GrowAriaLabel { get; set; } = "Grow column width"; | ||
|
|
||
| /// <summary> | ||
| /// Gets or sets the aria label for the shrink button in the discrete resize UI | ||
| /// </summary> | ||
| public string? ShrinkAriaLabel { get; set; } = "Shrink column width"; | ||
|
|
||
| /// <summary> | ||
| /// Gets or sets the aria label for the reset button in the resize UI | ||
| /// </summary> | ||
| public string? ResetAriaLabel { get; set; } = "Reset column widths"; | ||
|
|
||
| /// <summary> | ||
| /// Gets or sets the aria label for the submit button in the resize UI | ||
| /// </summary> | ||
| public string? SubmitAriaLabel { get; set; } = "Set column widths"; | ||
|
|
||
| /// <summary> | ||
| /// Gets the default labels for the resize UI. | ||
| /// </summary> | ||
| public static ColumnResizeLabels Default => new(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| // ------------------------------------------------------------------------ | ||
| // MIT License - Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // ------------------------------------------------------------------------ | ||
| namespace Microsoft.FluentUI.AspNetCore.Components; | ||
|
|
||
| public record ColumnSortLabels | ||
| { | ||
| /// <summary> | ||
| /// Gets or sets the text shown in the column menu | ||
| /// </summary> | ||
| public string SortMenu { get; set; } = "Sort"; | ||
|
|
||
| /// <summary> | ||
| /// Gets or sets the text shown in the column menu when in ascending order | ||
| /// </summary> | ||
| public string SortMenuAscendingLabel { get; set; } = "Sort (ascending)"; | ||
|
|
||
| /// <summary> | ||
| /// Gets or sets the text shown in the column menu when in descending order | ||
| /// </summary> | ||
| public string SortMenuDescendingLabel { get; set; } = "Sort (descending)"; | ||
|
|
||
| /// <summary> | ||
| /// Gets the default labels for the sort UI. | ||
| /// </summary> | ||
| public static ColumnSortLabels Default => new(); | ||
|
|
||
| } | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.