Skip to content

[Select] Change height in listbox style to use fit-content when Height value is provided #2680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vnbaaij merged 2 commits into from
Sep 18, 2024
Merged

[Select] Change height in listbox style to use fit-content when Height value is provided #2680

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbdd003
Chnage height to fit-content so listbox will be smaller if fewer opti…
vnbaaij Sep 18, 2024
8b42c04
Merge branch 'dev' into users/vnbaaij/fix-issue-#2676
dvoituron Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Chnage height to fit-content so listbox will be smaller if fewer opti… 
…ons are supplied
  • Loading branch information
@vnbaaij
vnbaaij committed Sep 18, 2024
commit dbdd003e82da039ee19eabfc1dfcdf5215124ffb
24 changes: 24 additions & 0 deletions examples/Demo/Shared/Microsoft.FluentUI.AspNetCore.Components.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1857,6 +1857,7 @@
ColumnOptions UI. This parameter allows you to enable or disable this resize UI.Enable it by setting the type of resize to perform
Discrete: resize by a 10 pixels at a time
Exact: resize to the exact width specified (in pixels)
Note: This does not affect resizing by mouse dragging, just the keyboard driven resize.
</summary>
</member>
<member name="P:Microsoft.FluentUI.AspNetCore.Components.FluentDataGrid`1.ColumnResizeLabels">
Expand Down Expand Up @@ -2050,6 +2051,29 @@
<member name="M:Microsoft.FluentUI.AspNetCore.Components.FluentDataGrid`1.DisposeAsync">
<inheritdoc />
</member>
<member name="M:Microsoft.FluentUI.AspNetCore.Components.FluentDataGrid`1.SetColumnWidthDiscreteAsync(System.Nullable{System.Int32},System.Single)">
<summary>
Resizes the column width by a discrete amount.
</summary>
<param name="columnIndex">The column to be resized</param>
<param name="widthChange">The amount of pixels to change width with</param>
<returns></returns>
</member>
<member name="M:Microsoft.FluentUI.AspNetCore.Components.FluentDataGrid`1.SetColumnWidthExactAsync(System.Int32,System.Int32)">
<summary>
Resizes the column width to the exact width specified (in pixels).
</summary>
<param name="columnIndex">The column to be resized</param>
<param name="width">The new width in pixels</param>
<returns></returns>
</member>
<member name="M:Microsoft.FluentUI.AspNetCore.Components.FluentDataGrid`1.ResetColumnWidthsAsync">
<summary>
Resets the column widths to their initial values as specified with the <see cref="P:Microsoft.FluentUI.AspNetCore.Components.FluentDataGrid`1.GridTemplateColumns"/> parameter.
If no value is specified, the default value is "1fr" for each column.
</summary>
<returns></returns>
</member>
<member name="P:Microsoft.FluentUI.AspNetCore.Components.FluentDataGridCell`1.Item">
<summary>
Gets or sets the reference to the item that holds this cell's values.
Expand Down
2 changes: 1 addition & 1 deletion src/Core/Components/List/FluentSelect.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ public partial class FluentSelect<TOption> : ListComponentBase<TOption> where TO
/// <summary />
protected virtual MarkupString InlineStyleValue => new InlineStyleBuilder()
.AddStyle($"#{Id}::part(listbox)", "max-height", Height, !string.IsNullOrWhiteSpace(Height))
.AddStyle($"#{Id}::part(listbox)", "height", Height, !string.IsNullOrWhiteSpace(Height))
.AddStyle($"#{Id}::part(listbox)", "height", "fit-content", !string.IsNullOrWhiteSpace(Height))
.AddStyle($"#{Id}::part(listbox)", "z-index", ZIndex.SelectPopup.ToString())
.AddStyle($"#{Id}::part(selected-value)", "white-space", "nowrap")
.AddStyle($"#{Id}::part(selected-value)", "overflow", "hidden")
Expand Down