Skip to content

Conversation

@miguelhasse
Copy link
Contributor

Pull Request

📖 Description

AsyncQueryExecutorSupplier modified so it looks-up multiple IAsyncQueryExecutor registrations and returns the first one that supports the provided IQueryable items source.

…yExecutor registrations and returns the first supporting match.
Copy link
Collaborator

@vnbaaij vnbaaij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give an example of how and why this is handy/better

@miguelhasse
Copy link
Contributor Author

@vnbaaij this change allows an application to use multiple different IQueryProvider implementations instead of a single one. Suppose for instance you want to use EF Core's DataContext and DataServiceQuery for OData queries.
I'm actually working on a IAsyncQueryExecutor adaptor for DataServiceQuery.

@vnbaaij
Copy link
Collaborator

vnbaaij commented Sep 27, 2024

I'm totally not up to speed on EF so don't know what DataServiceQuery does. But judging from the code this change does no do any harm.
Let's give @dvoituron a chance to review as well.

@dvoituron
Copy link
Collaborator

I don't have much experience of this either :-)

On the other hand, it would be interesting to add a Unit Test.
At the moment we don't have many tests for the FluentDataGrid, but we're working on the next version v5, which will require all features to be unit-tested. And as you have more experience than we do, adding a test right now would be great. Otherwise we will have to temporarily disable this feature :-(

@miguelhasse
Copy link
Contributor Author

@dvoituron sure I'll take care of adding unit tests for this feature.

@vnbaaij vnbaaij added this to the V4.10.2 milestone Oct 1, 2024
@vnbaaij vnbaaij modified the milestones: V4.10.2, v4.11 Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants