Skip to content

[Docs] Fix - Nullable reference types not always shown in API documentation #2758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vnbaaij merged 1 commit into from
Oct 4, 2024
Merged

[Docs] Fix - Nullable reference types not always shown in API documentation #2758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fixes ToTypeNameString to show Nullable
  • Loading branch information
@oneolddev
oneolddev committed Oct 4, 2024
commit 547da74114e91f7fb09353dec4ea00dcf1ecb3f1
10 changes: 8 additions & 2 deletions examples/Demo/Shared/ReflectionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,9 +181,12 @@ public static string ToTypeNameString(this ParameterInfo parameterInfo, Func<Typ
public static string ToTypeNameString(this MethodInfo methodInfo, Func<Type, Queue<string>, string> typeNameConverter = null,
bool invokeTypeNameConverterForGenericType = false)
{
bool isNullableType = !methodInfo.ReturnType.IsValueType
&& (new NullabilityInfoContext().Create(methodInfo.ReturnParameter).ReadState is NullabilityState.Nullable);

return methodInfo.ReturnType.ToNameStringWithValueTupleNames(
methodInfo.ReturnParameter?.GetCustomAttribute<TupleElementNamesAttribute>()?.TransformNames, typeNameConverter,
invokeTypeNameConverterForGenericType);
invokeTypeNameConverterForGenericType) + (isNullableType ? "?" : "");
}

/// <summary>
Expand All @@ -206,9 +209,12 @@ public static string ToTypeNameString(this MethodInfo methodInfo, Func<Type, Que
public static string ToTypeNameString(this PropertyInfo propertyInfo, Func<Type, Queue<string>, string> typeNameConverter = null,
bool invokeTypeNameConverterForGenericType = false)
{
bool isNullableType = !propertyInfo.PropertyType.IsValueType
&& (new NullabilityInfoContext().Create(propertyInfo).WriteState is NullabilityState.Nullable);

return propertyInfo.PropertyType.ToNameStringWithValueTupleNames(
propertyInfo.GetCustomAttribute<TupleElementNamesAttribute>()?.TransformNames, typeNameConverter,
invokeTypeNameConverterForGenericType);
invokeTypeNameConverterForGenericType) + (isNullableType ? "?" : "");
}

/// <summary>
Expand Down