-
Notifications
You must be signed in to change notification settings - Fork 460
[FileInput] Fix uploading the same file twice by drag&drop #2865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4572a7f
Fix #2849 by making the component more robust
vnbaaij 79cd81b
Fix tests
vnbaaij dde8204
Merge branch 'dev' into fix-issue-#2849
vnbaaij 2556b74
Fix z-index for content part
vnbaaij c03be80
Merge branch 'dev' into fix-issue-#2849
vnbaaij 06ead8c
Fix tests, remove superfluous space
vnbaaij 0af22ff
Merge branch 'fix-issue-#2849' of https://github.com/microsoft/fluent…
vnbaaij a118861
Disable paste functionality for now
vnbaaij File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 6 additions & 6 deletions
12
tests/Core/InputFile/FluentInputFileTests.FluentInputFile_Default.verified.razor.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
tests/Core/InputFile/FluentInputFileTests.FluentInputFile_Disabled.verified.razor.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 5 additions & 4 deletions
9
.../Core/InputFile/FluentInputFileTests.FluentInputFile_ProgressTemplate.verified.razor.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,10 @@ | ||
|
|
||
| <div class="fluent-inputfile-container" blazor:ondragenter="1" blazor:ondragenter:stoppropagation="" blazor:ondragover="2" blazor:ondragover:stoppropagation="" blazor:ondragleave="3" blazor:ondragleave:stoppropagation="" blazor:ondragend="4" b-72uj7bp8pi=""> | ||
| <div class="inputfile-content" style="z-index: 999" b-72uj7bp8pi="">Sample description | ||
| <div class="inputfile-progress" style="" b-72uj7bp8pi="">ProgressFileDetails { Index = 0, Name = , Percentage = 0 }</div> | ||
| </div> | ||
| <div class="inputfile-content" style="z-index: 991" b-72uj7bp8pi=""> | ||
| Sample description | ||
| <div class="inputfile-progress" style="" b-72uj7bp8pi="">ProgressFileDetails { Index = 0, Name = , Percentage = 0 }</div> | ||
| </div> | ||
| <div style="grid-column: 1; grid-row: 1; " b-72uj7bp8pi=""> | ||
| <input id="xxx" accept="" type="file" blazor:elementreference="xxx"> | ||
| </div> | ||
| </div> | ||
| </div> |
14 changes: 8 additions & 6 deletions
14
...s/Core/InputFile/FluentInputFileTests.FluentInputFile_UploadCompleted.verified.razor.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,13 @@ | ||
|
|
||
| <div class="fluent-inputfile-container" blazor:ondragenter="1" blazor:ondragenter:stoppropagation="" blazor:ondragover="2" blazor:ondragover:stoppropagation="" blazor:ondragleave="3" blazor:ondragleave:stoppropagation="" blazor:ondragend="4" b-72uj7bp8pi=""> | ||
| <div class="inputfile-content" style="z-index: 999" b-72uj7bp8pi="">Sample description | ||
| <div class="inputfile-progress" style="visibility: visible;" b-72uj7bp8pi=""> | ||
| <fluent-progress min="0" max="100" value="100" blazor:elementreference=""></fluent-progress> | ||
| <br b-72uj7bp8pi="">Completed</div> | ||
| </div> | ||
| <div class="inputfile-content" style="z-index: 991" b-72uj7bp8pi=""> | ||
| Sample description | ||
| <div class="inputfile-progress" style="visibility: visible;" b-72uj7bp8pi=""> | ||
| <fluent-progress min="0" max="100" value="100" blazor:elementreference=""></fluent-progress> | ||
| <br b-72uj7bp8pi="">Completed | ||
| </div> | ||
| </div> | ||
| <div style="grid-column: 1; grid-row: 1; " b-72uj7bp8pi=""> | ||
| <input id="xxx" multiple="" accept="image/*" type="file" blazor:elementreference=""> | ||
| </div> | ||
| </div> | ||
| </div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.