-
Notifications
You must be signed in to change notification settings - Fork 459
[Autocomplete] Fix Icon Titles (Dismiss and Search) and delete predefined element #2891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dvoituron
merged 6 commits into
dev
from
users/dvoituron/autocomplete/fix-title-delete-first
Nov 6, 2024
Merged
[Autocomplete] Fix Icon Titles (Dismiss and Search) and delete predefined element #2891
dvoituron
merged 6 commits into
dev
from
users/dvoituron/autocomplete/fix-title-delete-first
Nov 6, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 30, 2024
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 61.3%
|
vnbaaij
approved these changes
Nov 5, 2024
vnbaaij
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Autocomplete] Fix Icon Titles (Dismiss and Search) and delete predefined element
feat: add custom translation for Search/Clear icons to/in FluentAutocomplete #2873 - Add custom translation for Search/Clear icons.
You can use the static properties:
AccessibilityIconDismissandAccessibilityIconSearchfix: Pre-selected values cannot be deleted from FluentAutocomplete #2880 - When you have a predefined value assigned, it cannot be deleted unless you have selected another value.
Fixed.
Unit Tests
Passed