Skip to content

Conversation

@svrooij
Copy link
Contributor

@svrooij svrooij commented Nov 25, 2024

Fixed #2970

Pull Request

πŸ“– Description

Add support for html color picker

🎫 Issues

πŸ‘©β€πŸ’» Reviewer Notes

πŸ“‘ Test Plan

βœ… Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new component
  • I have modified an existing component
  • I have validated the Unit Tests for an existing component

⏭ Next Steps

@dvoituron
Copy link
Collaborator

It's certainly a good idea that we haven't worked on yet (although we don't know why πŸ˜‰).

To generalize this change, could you also add these types?
This would make it possible to have text types that don't currently exist in our Lib, while staying with the FluentUI style.

  • Color
  • Number
  • Search
  • Password

@svrooij
Copy link
Contributor Author

svrooij commented Nov 25, 2024

It's certainly a good idea that we haven't worked on yet (although we don't know why πŸ˜‰).

To generalize this change, could you also add these types? This would make it possible to have text types that don't currently exist in our Lib, while staying with the FluentUI style.

  • Color
  • Number
  • Search
  • Password

@dvoituron I added the Color in the PR, for Number you already have the number input. The Password value is already there and Search does not do anything else (in my browser).

What about the date related fields? Month, Date, DateTimeLocal, Week?

@dvoituron
Copy link
Collaborator

For Number you already have the number input. The Password value is already there and Search does not do anything else (in my browser).
What about the date related fields? Month, Date, DateTimeLocal, Week?

  • Some people have a problem with FluentNumberField encompassing the fluent-number-field element. This could be an alternative for them.
  • The same applies to the password, which would use the β€˜default’ HTML input element.
  • Search will be detected by the accessibility features of browsers as a β€˜search’ element: Enter sends the value to the server and a cross is displayed in Edge and Chrome when the component is active.
  • Date components already exist in FluentUI Lib and we never received issues about that :-)

@svrooij
Copy link
Contributor Author

svrooij commented Nov 25, 2024

Will add the number and the search.

@vnbaaij vnbaaij changed the title Add support for html color picker {TextField] Add support for additional field types Nov 25, 2024
@vnbaaij vnbaaij added this to the v4.11 milestone Nov 25, 2024
@vnbaaij vnbaaij merged commit d500630 into microsoft:dev Nov 25, 2024
4 checks passed
@vnbaaij vnbaaij changed the title {TextField] Add support for additional field types [TextField] Add support for additional field types Nov 25, 2024
@svrooij svrooij deleted the feature/input-type-color branch November 25, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add other input types to FluentTextField (color)

3 participants