Skip to content

[Tabs] Only render Label if Header is null #2989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vnbaaij merged 1 commit into from
Nov 29, 2024

Only render FluentTab Label if Header is null. Fixes #2988

e27db48
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

[Tabs] Only render Label if Header is null #2989

Only render FluentTab Label if Header is null. Fixes #2988
e27db48
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Actions / Core Tests succeeded Nov 29, 2024 in 1s

918 passed, 0 failed and 16 skipped

Tests passed successfully

✅ TestResults/runneradmin_fv-az1347-412_2024-11-29_15_24_15.trx

934 tests were completed in 3s with 918 passed, 0 failed and 16 skipped.

Test suite Passed Failed Skipped Time
Microsoft.FluentUI.AspNetCore.Components.Tests._ToDo.Stack.FluentSlackTests 1✅ 2ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Accordion.FluentAccordionItemTests 13✅ 21ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Accordion.FluentAccordionTests 9✅ 24ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Anchor.FluentAnchorTests 34✅ 86ms
Microsoft.FluentUI.AspNetCore.Components.Tests.AnchoredRegion.FluentAnchoredRegionTests 36✅ 126ms
Microsoft.FluentUI.AspNetCore.Components.Tests.AppBar.FluentAppBarItemTests 6✅ 27ms
Microsoft.FluentUI.AspNetCore.Components.Tests.AppBar.FluentAppBarTests 4✅ 103ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Badge.FluentBadgeTests 17✅ 83ms
Microsoft.FluentUI.AspNetCore.Components.Tests.BodyContent.FluentBodyContentTests 2✅ 5ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Breadcrumb.FluentBreadcrumbItemTests 29✅ 243ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Breadcrumb.FluentBreadcrumbTests 5✅ 13ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Button.FluentButtonTests 64✅ 137ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Card.FluentCardTests 13✅ 25ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Checkbox.FluentCheckboxTests 18✅ 36ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Checkbox.FluentCheckboxThreeStatesTests 8✅ 618ms
Microsoft.FluentUI.AspNetCore.Components.Tests.CollapsibleRegion.FluentCollapsibleRegionTests 4✅ 9ms
Microsoft.FluentUI.AspNetCore.Components.Tests.CounterBadge.FluentCounterBadgeTests 28✅ 95ms
Microsoft.FluentUI.AspNetCore.Components.Tests.DataGrid.DataGridSortByTests 4✅ 101ms
Microsoft.FluentUI.AspNetCore.Components.Tests.DataGrid.FluentDataGridColumSelectTests 17✅ 419ms
Microsoft.FluentUI.AspNetCore.Components.Tests.DataGrid.FluentDataGridTests 1⚪ 1ms
Microsoft.FluentUI.AspNetCore.Components.Tests.DataGrid.GridSortTests 10✅ 69ms
Microsoft.FluentUI.AspNetCore.Components.Tests.DateTime.CalendarExtendedTests 1✅ 0ms
Microsoft.FluentUI.AspNetCore.Components.Tests.DateTime.FluentCalendarSelectionTests 7✅ 137ms
Microsoft.FluentUI.AspNetCore.Components.Tests.DateTime.FluentCalendarTests 49✅ 991ms
Microsoft.FluentUI.AspNetCore.Components.Tests.DateTime.FluentDatePickerTests 12✅ 65ms
Microsoft.FluentUI.AspNetCore.Components.Tests.DateTime.FluentTimePickerTests 6✅ 7ms
Microsoft.FluentUI.AspNetCore.Components.Tests.DateTime.RangeOfTests 7✅ 7ms
Microsoft.FluentUI.AspNetCore.Components.Tests.DateTime.ToDateTimeExtensionsTests 25✅ 5ms
Microsoft.FluentUI.AspNetCore.Components.Tests.DateTime.ToTimeAgoTests 31✅ 5ms
Microsoft.FluentUI.AspNetCore.Components.Tests.DesignSystemProvider.FluentDesignSystemProviderTests 1✅ 16ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Dialog.FluentDialogServiceTests 5✅ 118ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Dialog.FluentDialogTests 3✅ 23ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Divider.FluentDividerTests 6✅ 16ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Drag.FluentDragTests 1✅ 11ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Emojis.FluentEmojiTests 1⚪ 1ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Extensions.AdditionalAttributesExtensionsShould 24✅ 1ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Flipper.FluentFlipperTests 2✅ 9ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Footer.FluentFooterTests 1✅ 3ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Forms.FluentValidationSummaryTests 1⚪ 1ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Grid.FluentGridTests 23✅ 78ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Header.FluentHeaderTests 3✅ 7ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Highlighter.FluentHighlighterTests 1✅ 4ms
Microsoft.FluentUI.AspNetCore.Components.Tests.HorizontalScroll.FluentHorizontalScrollTests 1✅ 8ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Icons.FluentIconTests 22✅ 39ms
Microsoft.FluentUI.AspNetCore.Components.Tests.InputFile.FluentInputFileTests 10✅ 484ms
Microsoft.FluentUI.AspNetCore.Components.Tests.KeyCodeProvider.FluentKeyCodeTests 13✅ 40ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Label.FluentInputLabelTests 5✅ 13ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Label.FluentLabelTests 20✅ 49ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Layout.FluentLayoutTests 4✅ 15ms
Microsoft.FluentUI.AspNetCore.Components.Tests.List.FluentAutocompleteTests 22✅ 421ms
Microsoft.FluentUI.AspNetCore.Components.Tests.List.FluentComboboxTests 3✅ 32ms
Microsoft.FluentUI.AspNetCore.Components.Tests.List.FluentListboxTests 6✅ 51ms
Microsoft.FluentUI.AspNetCore.Components.Tests.List.FluentPersonaTests 7✅ 63ms
Microsoft.FluentUI.AspNetCore.Components.Tests.List.FluentSelectTests 13✅ 60ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Main.FluentMainTests 1✅ 6ms
Microsoft.FluentUI.AspNetCore.Components.Tests.MainLayout.FluentMainLayoutTests 1✅ 18ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Menu.FluentMenuItemTests 1⚪ 1ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Menu.FluentMenuTests 1✅ 6ms
Microsoft.FluentUI.AspNetCore.Components.Tests.MenuButton.FluentMenuButtonTests 2✅ 31ms
Microsoft.FluentUI.AspNetCore.Components.Tests.MessageBar.FluentMessageBarTests 4✅ 19ms
Microsoft.FluentUI.AspNetCore.Components.Tests.MessageBar.MessageServiceTests 4✅ 138ms
Microsoft.FluentUI.AspNetCore.Components.Tests.NavMenu.FluentNavGroupTests 9✅ 55ms
Microsoft.FluentUI.AspNetCore.Components.Tests.NavMenu.FluentNavLinkTests 11✅ 180ms
Microsoft.FluentUI.AspNetCore.Components.Tests.NavMenu.FluentNavMenuTests 8✅ 20ms
Microsoft.FluentUI.AspNetCore.Components.Tests.NumberField.FluentNumberFieldTests 32✅ 103ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Overflow.FluentOverflowItemTests 1⚪ 1ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Overflow.FluentOverflowTests 1⚪ 1ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Overlay.FluentOverlayTests 1✅ 8ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Pagination.FluentPaginatorTests 1⚪ 1ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Popover.FluentPopoverTests 1✅ 3ms
Microsoft.FluentUI.AspNetCore.Components.Tests.PresenceBadge.FluentPresenceBadgeTests 1⚪ 1ms
Microsoft.FluentUI.AspNetCore.Components.Tests.ProfileMenu.FluentProfileMenuTests 5✅ 64ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Progress.FluentProgressRingTests 8✅ 31ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Progress.FluentProgressTests 7✅ 14ms
Microsoft.FluentUI.AspNetCore.Components.Tests.PullToRefresh.FluentPullToRefreshTests 20✅ 91ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Radio.FluentRadioGroupTests 1✅ 9ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Radio.FluentRadioTests 1⚪ 1ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Rating.FluentRatingTests 13✅ 99ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Search.FluentSearchTests 1⚪ 1ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Skeleton.FluentSkeletonTests 1✅ 503ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Slider.FluentSliderLabelTests 1✅ 5ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Slider.FluentSliderTests 7✅ 633ms
Microsoft.FluentUI.AspNetCore.Components.Tests.SortableList.FluentSortableListTests 3✅ 32ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Spacer.FluentSpacerTests 1✅ 3ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Splitter.FluentMultiSplitterTests 9✅ 91ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Splitter.FluentSplitterTests 15✅ 39ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Stack.FluentStackTests 1✅ 5ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Switch.FluentSwitchTests 1✅ 5ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Tabs.FluentTabsTests 1⚪ 1ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Tabs.FluentTabTests 1⚪ 1ms
Microsoft.FluentUI.AspNetCore.Components.Tests.TextArea.FluentTextAreaTests 1✅ 12ms
Microsoft.FluentUI.AspNetCore.Components.Tests.TextField.FluentTextFieldTests 1✅ 6ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Toast.FluentToastProviderTests 1⚪ 1ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Toast.FluentToastTests 1⚪ 1ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Toolbar.FluentToolbarTests 1✅ 4ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Tooltip.FluentTooltipTests 2✅ 10ms
Microsoft.FluentUI.AspNetCore.Components.Tests.TreeView.FluentTreeViewItemsTests 11✅ 66ms
Microsoft.FluentUI.AspNetCore.Components.Tests.TreeView.FluentTreeViewTests 3✅ 7ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Utilities.CssBuilderTests 18✅ 4ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Utilities.DebounceActionTests 8✅ 1⚪ 647ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Utilities.DebounceTaskTests 7✅ 1⚪ 521ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Utilities.InlineStyleBuilderTests 7✅ 4ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Utilities.SplitterTests 3✅ 30ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Utilities.StyleBuilderTests 11✅ 2ms
Microsoft.FluentUI.AspNetCore.Components.Tests.Wizard.FluentWizardTests 21✅ 418ms
View more details on GitHub Actions