-
Notifications
You must be signed in to change notification settings - Fork 461
[DataGrid] Respecting control state of Loading parameter #3064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦oading is set back to null.
adamint
commented
Dec 18, 2024
adamint
commented
Dec 18, 2024
adamint
commented
Dec 18, 2024
vnbaaij
approved these changes
Dec 19, 2024
vnbaaij
added a commit
that referenced
this pull request
Jan 29, 2025
β¦y took `ItemsProvider` into account
vnbaaij
added a commit
that referenced
this pull request
Jan 29, 2025
β¦y took `ItemsProvider` into account (#3265) Co-authored-by: Denis Voituron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π Description
π« Issues
Fixes #2998
π©βπ» Reviewer Notes
This PR changes
FluentDataGrid.Loadingto a nullable boolean. If the value is not-null, the grid is considered controlled and requires the user to change loading state themselves. If the value is null, the grid will manage loading state itself - ifItemsare provided, Loading is set to false, otherwise Loading is true until theItemsProviderhas returned data.This also fixes the issue where initially
EmptyContentis rendered if there is an ItemsProvider when the grid should be renderingLoadingContent.As a smoke test, you can look at the "Remote Data" section on the DataGrid demo example page, which now shows a loading page before content is loaded.
π Test Plan
I've added a basic DataGrid test as well as several tests surrounding Loading, with either ItemsProvider or Items.
β Checklist
General
Component-specific
β Next Steps