[FluentSlider] [FluentNumberField] Fix #2948

[oneolddev]

Pull Request

📖 Description

Fixes issues reported in #2948. Two issue reported both related to changing the value of the control programatically.

🎫 Issues

The underlying issue is that the web components being wrapped were designed to have there states only changed interactively. bind-value does not behave as expected. Inward binding works only on for initialization. Outward binding works as expected.

This gives the appearance of a sync issue.

👩‍💻 Reviewer Notes

FluentSlider - #2665 did not fully fix #2609. The original fix was to prevent the flickering when the slider was moved rapidly originally reported. I was not able to reproduce this problem with the current implementation of FluentDataGrid. I did end up adding debouncing with the DebounceAction. I believe I did this correctly.

FluentNumberField - The fix was to ensure the underlying web component reflected the correct value. I could not find a way of distinguishing if the value was changed by manipulating the control or if it was changed programatically. I opted to use some javascript to force the value in the web component. I also added a DisposeAsync. It was missing.

I've also included an issue-tester page as part of this draft

📑 Test Plan

✅ Checklist

General

• I have added tests for my changes.
• I have tested my changes.
• I have updated the project documentation to reflect my changes.
• I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

• I have added a new component
• I have added Unit Tests for my new component
• I have modified an existing component
• I have validated the Unit Tests for an existing component

[vnbaaij]

Will test this soop

[oneolddev]

@vnbaaij

I've fixed the unit test by easing the BUnit JSInterop mode. I'm not sure if that breaks any testing conventions.

Should this be split into two PRs? One for FluentSlider and one for FluentNumberField.

[oneolddev]

Found another issue with my fix for FluentNumberField 😞

When typing directly into the control, it would flicker and lose the change.

[dvoituron]

Next time, please create one PR to fix one problem. This makes it easier to maintain the code.
Thank you :-)