Skip to content

[Accordion] Fix Expanded state not being set in OnAccordionItemChange #3092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vnbaaij merged 3 commits into from
Dec 23, 2024
Merged

[Accordion] Fix Expanded state not being set in OnAccordionItemChange #3092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab25ea8
Fix #3087
vnbaaij Dec 23, 2024
cbcb401
Fix #3086
vnbaaij Dec 23, 2024
16a369d
Merge branch 'dev' into users/vnbaaij/fix-issue-#3086
vnbaaij Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/Demo/Shared/Pages/Accordion/Examples/AccordionDefault.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
</FluentAccordionItem>
</FluentAccordion>

<p>Last changed accordion item: @(changed?.Heading ?? "item with HeaderTemplate")</p>
<p>Last changed accordion item: @(changed?.Heading ?? "item with HeaderTemplate"), Expanded: @changed?.Expanded</p>


@code {
Expand All @@ -35,4 +35,4 @@
{
changed = item;
}
}
}
5 changes: 5 additions & 0 deletions src/Core/Components/Accordion/FluentAccordion.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
// ------------------------------------------------------------------------
// MIT License - Copyright (c) Microsoft Corporation. All rights reserved.
// ------------------------------------------------------------------------

using System.Diagnostics.CodeAnalysis;
using Microsoft.AspNetCore.Components;

Expand Down Expand Up @@ -52,6 +56,7 @@ private async Task HandleOnAccordionChangedAsync(AccordionChangeEventArgs args)
var Id = args.ActiveId;
if (Id is not null && items.TryGetValue(Id!, out FluentAccordionItem? item))
{
item.Expanded = args.Expanded;
await OnAccordionItemChange.InvokeAsync(item);
await ActiveIdChanged.InvokeAsync(Id);
}
Expand Down
Loading