Skip to content

[DataGrid] [AppBar] Set FluentComponentBase.Element to a correct value #3222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dvoituron merged 2 commits into from
Jan 21, 2025
Merged

[DataGrid] [AppBar] Set FluentComponentBase.Element to a correct value #3222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e86efb
Fix #3212 by setting FluentComponentBase.Element to a correct value.
vnbaaij Jan 20, 2025
b7e7c39
Merge branch 'dev' into users/vnbaaij/fix-issue-#3212
dvoituron Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/Demo/Shared/wwwroot/docs/DesignTokens.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ Given the following `.razor` page fragment:

```cshtml
<FluentButton @ref="ref1">A button</FluentButton>
<FluentButton @ref="ref2" Appearance.Accent>Another button</FluentButton>
<FluentButton @ref="ref2" Appearance="Appearance.Accent">Another button</FluentButton>
<FluentButton @ref="ref3">And one more</FluentButton>
<FluentButton @ref="ref4" @onclick=OnClick>Last button</FluentButton>
```
Expand Down
2 changes: 1 addition & 1 deletion src/Core/Components/AppBar/FluentAppBar.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
@inherits FluentComponentBase

<CascadingValue TValue="InternalAppBarContext" Value="@_internalAppBarContext" IsFixed="true">
<nav id="@Id" @attributes="AdditionalAttributes" class="@ClassValue" style="@StyleValue" role="navigation" orientation="@Orientation.ToAttributeValue()">
<nav @ref="@Element" id="@Id" @attributes="AdditionalAttributes" class="@ClassValue" style="@StyleValue" role="navigation" orientation="@Orientation.ToAttributeValue()">

@if (Items is null)
{
Expand Down
1 change: 1 addition & 0 deletions src/Core/Components/AppBar/FluentAppBar.razor.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
}

::deep div[part="label"] {
color: var(--neutral-foreground-rest);
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
Expand Down
1 change: 1 addition & 0 deletions src/Core/Components/DataGrid/FluentDataGrid.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,6 +426,7 @@ protected override async Task OnAfterRenderAsync(bool firstRender)
{
if (firstRender && _gridReference is not null)
{
Element = _gridReference.Value;
Module ??= await JSRuntime.InvokeAsync<IJSObjectReference>("import", JAVASCRIPT_FILE.FormatCollocatedUrl(LibraryConfiguration));
try
{
Expand Down
Loading