Skip to content

[DataGrid] Small optimization to the number of times data needs to be refreshed #3265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vnbaaij merged 2 commits into from
Jan 29, 2025
Merged

[DataGrid] Small optimization to the number of times data needs to be refreshed #3265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12b63f2
Fix 3261 by fine tunning a change that was made in PR #3064 which onl…
vnbaaij Jan 29, 2025
606ac1a
Merge branch 'dev' into users/vnbaaij/fix-issue-#3261
dvoituron Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions examples/Demo/Shared/Pages/DataGrid/Pages/DataGridAutoItemsPerPagePage.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
}

.demo-section-example {
min-height: 135px!important;
height: 100%;
}

Expand Down Expand Up @@ -74,6 +75,7 @@
}

.demo-section-example {
min-height: 135px !important;
height: 100%;
}

Expand Down
2 changes: 1 addition & 1 deletion src/Core/Components/DataGrid/FluentDataGrid.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ protected override Task OnParametersSetAsync()
Pagination?.ItemsPerPage != _lastRefreshedPaginationState?.ItemsPerPage
|| Pagination?.CurrentPageIndex != _lastRefreshedPaginationState?.CurrentPageIndex;

var mustRefreshData = dataSourceHasChanged || paginationStateHasChanged || Loading is null;
var mustRefreshData = dataSourceHasChanged || paginationStateHasChanged || EffectiveLoadingValue;

// We don't want to trigger the first data load until we've collected the initial set of columns,
// because they might perform some action like setting the default sort order, so it would be wasteful
Expand Down
Loading