Skip to content

[Tabs] Fix Overflow getting out of sync with tab collection #3284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vnbaaij merged 5 commits into from
Feb 7, 2025
Merged

[Tabs] Fix Overflow getting out of sync with tab collection #3284

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
38be2bc
Replace Dictionary with a List and fix overflow keeping closed items.…
vnbaaij Feb 1, 2025
d3b3a8e
Merge branch 'dev' into users/vnbaaij/fix-issue-#3268
vnbaaij Feb 7, 2025
066591d
Process review comments. For now we will go with the quick fix
vnbaaij Feb 7, 2025
8a1e97e
Remove unneccesary null negating
vnbaaij Feb 7, 2025
23c3f6a
Merge branch 'dev' into users/vnbaaij/fix-issue-#3268
vnbaaij Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unneccesary null negating
  • Loading branch information
@vnbaaij
vnbaaij committed Feb 7, 2025
commit 8a1e97ead4ea27e058603b08a2d234bcd7173972
4 changes: 2 additions & 2 deletions src/Core/Components/Tabs/FluentTab.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ public FluentTab()

protected override void OnInitialized()
{
Index = Owner!.RegisterTab(this);
Index = Owner.RegisterTab(this);
}

/// <summary />
Expand All @@ -156,7 +156,7 @@ protected virtual Task CloseClickedAsync()
{
return Task.CompletedTask;
}
return Owner!.UnregisterTabAsync(Id);
return Owner.UnregisterTabAsync(Id);
}

/// <summary />
Expand Down
Loading