Skip to content

Conversation

@joriverm
Copy link
Contributor

@joriverm joriverm commented Feb 3, 2025

Pull Request

📖 Description

autocomplete doesnt trigger the fieldchanged as the default ChangeHandler, which handles the validation/fieldchanged event of the editform, this was fixed by always triggering the event on selection changes for both single and multiple mode.

i also noticed that the list base didnt implement the binding expression property, so the fieldidentifier was always wrong.

🎫 Issues

Fix #3115

👩‍💻 Reviewer Notes

this was tested using the form page from the demo project. i am currently going through the tests to check out if i missed anything

📑 Test Plan

none, i dont see how to put this in a test without adding a binding the bunit test and rendering a validator at the same time. not sure if its worth it?

✅ Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new component
  • I have modified an existing component
  • I have validated the Unit Tests for an existing component

⏭ Next Steps

N/A

@joriverm joriverm marked this pull request as ready for review February 4, 2025 08:33
@joriverm joriverm requested a review from vnbaaij as a code owner February 4, 2025 08:33
@joriverm joriverm requested a review from dvoituron February 4, 2025 08:53
@joriverm joriverm force-pushed the fixes/AutoCompleteContext branch from 2640484 to f20017f Compare February 4, 2025 14:29
@joriverm joriverm force-pushed the fixes/AutoCompleteContext branch from f20017f to 3107fd6 Compare February 4, 2025 15:07
@vnbaaij vnbaaij changed the title ListComponentBase : trigger fieldchanged in multiple mode #3115 [Lists] Trigger field changed when in multiple mode Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add Validation to/in Autocomplete control

3 participants