Skip to content

[NumberField] Unsigned integer values and fixes #3373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vnbaaij merged 12 commits into from
Feb 18, 2025
Merged

[NumberField] Unsigned integer values and fixes #3373

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5331237
Most printing issues fixed
PascalVorwerk Feb 15, 2025
64a5bc8
Fix for really large images in print mode
PascalVorwerk Feb 15, 2025
f4d0cc2
Unsigned integer values and tests
PascalVorwerk Feb 16, 2025
f2983dc
Unsigned integer values and tests
PascalVorwerk Feb 16, 2025
a714920
Merge remote-tracking branch 'origin/users/pcwvorwerk/fix-issue-2882'…
PascalVorwerk Feb 16, 2025
7db67a5
Fixed hardcoded min/max values
PascalVorwerk Feb 16, 2025
96c3dc9
Removed old long checks causing a error
PascalVorwerk Feb 16, 2025
6e47c58
Added option parameter to opt-in for typed constraints instead of def…
PascalVorwerk Feb 16, 2025
432c142
Changed some docs
PascalVorwerk Feb 17, 2025
f378621
PR review comments and reverted old unit tests to old versions
PascalVorwerk Feb 17, 2025
2c00eaf
1 more unit test that changed..
PascalVorwerk Feb 17, 2025
e2a6446
Fixed min max value issues with web component and fixed issue with no…
PascalVorwerk Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
PR review comments and reverted old unit tests to old versions
  • Loading branch information
@PascalVorwerk
PascalVorwerk committed Feb 17, 2025
commit f3786213fc7286b3f01584ccfa99b0b07d771001
37 changes: 3 additions & 34 deletions src/Core/Components/NumberField/FluentNumberField.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,42 +104,12 @@ public partial class FluentNumberField<TValue> : FluentInputBase<TValue>, IAsync
private static readonly string _stepAttributeValue = GetStepAttributeValue();

// If type constraints is true and min is null, set min to the minimum value of TValue.
private string? MinValue
{
get
{
if (UseTypeConstraints && Min == null)
{
return InputHelpers<TValue>.GetMinValue();
}

return Min;
}
set
{
Min = value;
}
}
private string? MinValue => UseTypeConstraints && Min == null ? InputHelpers<TValue>.GetMinValue() : Min;

// If type constraints is true and max is null, set max to the maximum value of TValue.
private string? MaxValue
{
get
{
if (UseTypeConstraints && Max == null)
{
return InputHelpers<TValue>.GetMaxValue();
}
private string? MaxValue => UseTypeConstraints && Max == null ? InputHelpers<TValue>.GetMaxValue() : Max;

return Max;
}
set
{
Max = value;
}
}

private static string GetStepAttributeValue()
private static string GetStepAttributeValue()
{
var targetType = Nullable.GetUnderlyingType(typeof(TValue)) ?? typeof(TValue);
if (targetType == typeof(sbyte) ||
Expand Down Expand Up @@ -203,7 +173,6 @@ protected override bool TryParseValueFromString(string? value, [MaybeNullWhen(fa
result = default!;
}


validationErrorMessage = string.Format(CultureInfo.InvariantCulture, ParsingErrorMessage, FieldBound ? FieldIdentifier.FieldName : UnknownBoundField);
return false;
}
Expand Down
2 changes: 1 addition & 1 deletion ...re/NumberField/FluentNumberFieldTests.FluentNumberField_AdditionalParameter.verified.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" additional-parameter-name="additional-parameter-value" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" additional-parameter-name="additional-parameter-value" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion ...e/NumberField/FluentNumberFieldTests.FluentNumberField_AdditionalParameters.verified.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" additional-parameter1-name="additional-parameter1-value" additional-parameter2-name="additional-parameter2-value" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" additional-parameter1-name="additional-parameter1-value" additional-parameter2-name="additional-parameter2-value" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion ...erField/FluentNumberFieldTests.FluentNumberField_AppearanceParameter-Filled.verified.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="filled" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="filled" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion ...rField/FluentNumberFieldTests.FluentNumberField_AppearanceParameter-Outline.verified.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion ...ore/NumberField/FluentNumberFieldTests.FluentNumberField_AutoFocusParameter.verified.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field autofocus="" maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field autofocus="" maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion tests/Core/NumberField/FluentNumberFieldTests.FluentNumberField_ClassParameter.verified.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field class="additional-css-class" maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field class="additional-css-class" maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion ...Core/NumberField/FluentNumberFieldTests.FluentNumberField_DataListParameter.verified.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field list="datalist" maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field list="datalist" maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion tests/Core/NumberField/FluentNumberFieldTests.FluentNumberField_Default.verified.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion ...Core/NumberField/FluentNumberFieldTests.FluentNumberField_DisabledParameter.verified.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" disabled="" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" disabled="" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion ...Core/NumberField/FluentNumberFieldTests.FluentNumberField_HideStepParameter.verified.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field hide-step="" maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field hide-step="" maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion tests/Core/NumberField/FluentNumberFieldTests.FluentNumberField_IdParameter.verified.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion tests/Core/NumberField/FluentNumberFieldTests.FluentNumberField_Label.verified.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@

<label for="xxx" class="fluent-input-label" b-hum22yrq17="">My label
</label>
<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
4 changes: 2 additions & 2 deletions tests/Core/NumberField/FluentNumberFieldTests.FluentNumberField_LabelTemplate.verified.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

<label for="xxx" class="fluent-input-label" b-hum22yrq17="">
<h1>My label</h1>
<h1>My label</h1>
</label>
<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion ...ore/NumberField/FluentNumberFieldTests.FluentNumberField_MaxLengthParameter.verified.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field maxlength="10" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="10" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion tests/Core/NumberField/FluentNumberFieldTests.FluentNumberField_MaxParameter.verified.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field maxlength="14" minlength="1" size="20" step="1" max="2147483647" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="14" minlength="1" size="20" step="1" max="2147483647" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion tests/Core/NumberField/FluentNumberFieldTests.FluentNumberField_MinParameter.verified.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field maxlength="14" minlength="1" size="20" step="1" min="-2147483648" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="14" minlength="1" size="20" step="1" min="-2147483648" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion tests/Core/NumberField/FluentNumberFieldTests.FluentNumberField_NameParameter.verified.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" name="xxx" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" name="xxx" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion ...e/NumberField/FluentNumberFieldTests.FluentNumberField_PlaceholderParameter.verified.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field placeholder="placeholder-value" maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field placeholder="placeholder-value" maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion ...Core/NumberField/FluentNumberFieldTests.FluentNumberField_RequiredParameter.verified.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" required="" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" required="" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion tests/Core/NumberField/FluentNumberFieldTests.FluentNumberField_SizeParameter.verified.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field maxlength="14" minlength="1" size="3" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="14" minlength="1" size="3" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion tests/Core/NumberField/FluentNumberFieldTests.FluentNumberField_StepParameter.verified.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field maxlength="14" minlength="1" size="20" step="3" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field maxlength="14" minlength="1" size="20" step="3" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
2 changes: 1 addition & 1 deletion tests/Core/NumberField/FluentNumberFieldTests.FluentNumberField_StyleParameter.verified.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@

<fluent-number-field style="background-color: red;" maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>
<fluent-number-field style="background-color: red;" maxlength="14" minlength="1" size="20" step="1" id="xxx" value="100" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx">100</fluent-number-field>