-
Notifications
You must be signed in to change notification settings - Fork 459
[Search] Fix deletion if Disabled/Readonly #3433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vnbaaij
merged 7 commits into
microsoft:dev
from
PascalVorwerk:users/pcwvorwerk/fix-3430-fluentsearch
Feb 24, 2025
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
bfd02b9
FluentSearch fix #3430
PascalVorwerk 723906e
FluentSearch fix #3430
PascalVorwerk d4fc7be
Merge remote-tracking branch 'origin/users/pcwvorwerk/fix-3430-fluentβ¦
PascalVorwerk d305d6f
Removed accidental double Module line.
PascalVorwerk 6d44861
Fixed issue through css property instead of javascript call
PascalVorwerk 81e8f2c
Undo new line removal
PascalVorwerk a82ed4d
Merge branch 'dev' into users/pcwvorwerk/fix-3430-fluentsearch
vnbaaij File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
FluentSearch fix #3430
- Loading branch information
commit bfd02b9f18bcccd1b4e22b5b3711d1916d38d2dd
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
tests/Core/Search/FluentSearchTests.FluentSearch_AdditionalAttributes.verified.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
|
|
||
| <fluent-search id="xxx" appearance="outline" blazor:onchange="1" blazor:oninput="2" additional-attribute-name="additional-attribute-value" blazor:elementreference="xxx"></fluent-search> |
2 changes: 2 additions & 0 deletions
2
tests/Core/Search/FluentSearchTests.FluentSearch_AppearanceAttribute-Filled.verified.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
|
|
||
| <fluent-search id="xxx" appearance="filled" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx"></fluent-search> |
2 changes: 2 additions & 0 deletions
2
tests/Core/Search/FluentSearchTests.FluentSearch_AppearanceAttribute-Outline.verified.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
|
|
||
| <fluent-search id="xxx" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx"></fluent-search> |
2 changes: 2 additions & 0 deletions
2
tests/Core/Search/FluentSearchTests.FluentSearch_AutoFocusAttribute.verified.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
|
|
||
| <fluent-search autofocus="" id="xxx" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx"></fluent-search> |
4 changes: 4 additions & 0 deletions
4
tests/Core/Search/FluentSearchTests.FluentSearch_ChildContent.verified.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
|
|
||
| <fluent-search id="xxx" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx"> | ||
| <div>Child content</div> | ||
| </fluent-search> |
2 changes: 2 additions & 0 deletions
2
tests/Core/Search/FluentSearchTests.FluentSearch_DataListAttribute.verified.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
|
|
||
| <fluent-search list="datalist-id" id="xxx" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx"></fluent-search> |
2 changes: 2 additions & 0 deletions
2
tests/Core/Search/FluentSearchTests.FluentSearch_Default.verified.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
|
|
||
| <fluent-search id="xxx" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx"></fluent-search> |
2 changes: 2 additions & 0 deletions
2
tests/Core/Search/FluentSearchTests.FluentSearch_DisabledAttribute.verified.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
|
|
||
| <fluent-search id="xxx" disabled="" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx"></fluent-search> |
2 changes: 2 additions & 0 deletions
2
tests/Core/Search/FluentSearchTests.FluentSearch_IdAttribute-[empty].verified.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
|
|
||
| <fluent-search id="" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx"></fluent-search> |
2 changes: 2 additions & 0 deletions
2
tests/Core/Search/FluentSearchTests.FluentSearch_IdAttribute-[null].verified.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
|
|
||
| <fluent-search appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx"></fluent-search> |
2 changes: 2 additions & 0 deletions
2
tests/Core/Search/FluentSearchTests.FluentSearch_IdAttribute-[space].verified.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
|
|
||
| <fluent-search id=" " appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx"></fluent-search> |
2 changes: 2 additions & 0 deletions
2
tests/Core/Search/FluentSearchTests.FluentSearch_IdAttribute-id-value.verified.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
|
|
||
| <fluent-search id="xxx" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx"></fluent-search> |
2 changes: 2 additions & 0 deletions
2
tests/Core/Search/FluentSearchTests.FluentSearch_MaxLengthAttribute.verified.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
|
|
||
| <fluent-search maxlength="10" id="xxx" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx"></fluent-search> |
2 changes: 2 additions & 0 deletions
2
tests/Core/Search/FluentSearchTests.FluentSearch_MinLengthAttribute.verified.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
|
|
||
| <fluent-search minlength="5" id="xxx" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx"></fluent-search> |
2 changes: 2 additions & 0 deletions
2
tests/Core/Search/FluentSearchTests.FluentSearch_NameAttribute.verified.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
|
|
||
| <fluent-search id="xxx" name="xxx" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx"></fluent-search> |
2 changes: 2 additions & 0 deletions
2
tests/Core/Search/FluentSearchTests.FluentSearch_PatternAttribute.verified.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
|
|
||
| <fluent-search pattern="[A-Za-z]{3}" id="xxx" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx"></fluent-search> |
2 changes: 2 additions & 0 deletions
2
tests/Core/Search/FluentSearchTests.FluentSearch_PlaceholderAttribute.verified.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
|
|
||
| <fluent-search placeholder="Enter text here" id="xxx" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx"></fluent-search> |
2 changes: 2 additions & 0 deletions
2
tests/Core/Search/FluentSearchTests.FluentSearch_ReadOnlyAttribute.verified.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
|
|
||
| <fluent-search readonly="" id="xxx" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx"></fluent-search> |
2 changes: 2 additions & 0 deletions
2
tests/Core/Search/FluentSearchTests.FluentSearch_RequiredAttribute.verified.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
|
|
||
| <fluent-search id="xxx" required="" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx"></fluent-search> |
2 changes: 2 additions & 0 deletions
2
tests/Core/Search/FluentSearchTests.FluentSearch_SizeAttribute.verified.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
|
|
||
| <fluent-search size="10" id="xxx" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx"></fluent-search> |
2 changes: 2 additions & 0 deletions
2
tests/Core/Search/FluentSearchTests.FluentSearch_SpellcheckAttribute.verified.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
|
|
||
| <fluent-search spellcheck="" id="xxx" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx"></fluent-search> |
2 changes: 2 additions & 0 deletions
2
tests/Core/Search/FluentSearchTests.FluentSearch_ValueAttribute-[empty].verified.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
|
|
||
| <fluent-search id="xxx" value="" current-value="" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx"></fluent-search> |
2 changes: 2 additions & 0 deletions
2
tests/Core/Search/FluentSearchTests.FluentSearch_ValueAttribute-[null].verified.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
|
|
||
| <fluent-search id="xxx" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx"></fluent-search> |
2 changes: 2 additions & 0 deletions
2
tests/Core/Search/FluentSearchTests.FluentSearch_ValueAttribute-[space].verified.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
|
|
||
| <fluent-search id="xxx" value=" " current-value=" " appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx"></fluent-search> |
2 changes: 2 additions & 0 deletions
2
tests/Core/Search/FluentSearchTests.FluentSearch_ValueAttribute-some-value.verified.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
|
|
||
| <fluent-search id="xxx" value="some-value" current-value="some-value" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx"></fluent-search> |
4 changes: 4 additions & 0 deletions
4
tests/Core/Search/FluentSearchTests.FluentSearch_WithLabel.verified.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
|
|
||
| <label for="xxx" class="fluent-input-label" b-hum22yrq17="">With a label | ||
| </label> | ||
| <fluent-search id="xxx" appearance="outline" blazor:onchange="1" blazor:oninput="2" blazor:elementreference="xxx"></fluent-search> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.