Skip to content

[DataGrid] Only add Selectable items when using Select All #3453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dvoituron merged 2 commits into from
Feb 27, 2025
Merged

[DataGrid] Only add Selectable items when using Select All #3453

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
762f061
Only add Selecatable items when using Select All
vnbaaij Feb 26, 2025
6e39300
Fix test by apllying correct default value
vnbaaij Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/Core/Components/DataGrid/Columns/SelectColumn.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
// ------------------------------------------------------------------------
// MIT License - Copyright (c) Microsoft Corporation. All rights reserved.
// ------------------------------------------------------------------------

using Microsoft.AspNetCore.Components;
using Microsoft.AspNetCore.Components.Rendering;
using Microsoft.AspNetCore.Components.Web;
Expand Down Expand Up @@ -528,7 +532,11 @@ internal async Task OnClickAllAsync(MouseEventArgs e)
_selectedItems.Clear();
if (SelectAll == true)
{
_selectedItems.AddRange(InternalGridContext.Grid.Items?.ToArray() ?? InternalGridContext.Items);
// Only add selectable items
_selectedItems.AddRange((InternalGridContext.Grid.Items?.ToList() ?? InternalGridContext.Items)
.Where(item => Selectable?.Invoke(item) ?? false)
.ToArray()
);
}

if (SelectedItemsChanged.HasDelegate)
Expand Down
Loading